Added possibility to control hpf bias camera value#228
Open
DariaBerretta wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends cpp_tools/atis3-bridge’s atis3Bridge module with additional runtime camera configuration controls, mainly around event filtering and camera bias inspection/adjustment to support more flexible tuning and diagnostics.
Changes:
- Added new CLI options for temporal/spatial noise filtering (
--refr_filter,--sppt_filter) and HPF bias control (--hpf). - Added a
--print_biasesoption plus ashow_biases()helper to print all available camera biases (MetavisionSDK builds). - Updated filter initialization and logging to support enabling temporal and/or spatial filtering independently.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+138
to
+143
| int hpf = 0; | ||
| if (rf.check("hpf")) | ||
| hpf = rf.find("hpf").asInt32(); | ||
| if(hpf < 0) hpf = 1; | ||
| if(hpf > 99) hpf = 99; | ||
|
|
Comment on lines
+167
to
+171
| if(hpf) { | ||
| int bias_hpf = (int)(1400 + ((hpf*0.01)*(1499-1400))); | ||
| yInfo() << "After calculation:" << bias_hpf; | ||
| bias_control->set("bias_hpf", bias_hpf); | ||
| bias_vals = bias_control->get_all_biases(); |
Comment on lines
+183
to
+185
| if(hpf) { | ||
| yWarning() << "high-pass filter bias not implemented for Gen4"; | ||
| } |
Comment on lines
210
to
+214
| double nf_param = 0.0; | ||
| double sppt_filter = 0.0; | ||
| if(rf.check("refr_filter")) nf_param = rf.find("refr_filter").asFloat64(); | ||
| if(rf.check("filter")) nf_param = rf.find("filter").asFloat64(); | ||
| if(rf.check("f")) nf_param = rf.find("f").asFloat64(); | ||
| if(nf_param > 0.0) | ||
|
|
Comment on lines
+199
to
+201
| if(rf.check("print_biases")) { | ||
| show_biases(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds several new camera configuration options and features to the
atis3Bridgemodule to provide more flexible control over event filtering and bias settings. The most important changes include new command-line arguments for advanced filtering and bias management, as well as logic to handle these options and display all camera biases.New camera filtering and bias configuration options:
--refr_filter(temporal filter),--sppt_filter(spatial filter), and--hpf(high-pass filter bias) command-line arguments, allowing fine-grained control over event rate and bias settings. [1] [2] [3]Camera bias management:
--print_biasesoption and a newshow_biases()method to print all available camera biases for debugging and calibration. [1] [2] [3]Event filtering enhancements:
refr_filter) and spatial (sppt_filter) event filters, with clear logging and initialization logic for each.Minor improvements:
These changes provide users with greater flexibility and insight into camera configuration, especially for advanced tuning and diagnostics.