Update to work with Drupal 10 and allow parsing Excel and ODS spreadsheets#1
Open
whikloj wants to merge 6 commits into
Open
Update to work with Drupal 10 and allow parsing Excel and ODS spreadsheets#1whikloj wants to merge 6 commits into
whikloj wants to merge 6 commits into
Conversation
Allow configuration to skip empty rows in openspout and Papaparse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I appreciate the work on this, it helped me get my head around some of the Drupal code.
We have a bunch of census data in Excel documents and we wanted to be able to display it.
This code does CSV, so I added an endpoint that returns an Excel or OpenDocumentSpreadsheet as a CSV.
There might be more work needed, but this is good for us for now.
So I wanted to contribute back. Because this is not compatible with Drupal 8 and 9 you may want to close this PR and start a new branch for Drupal 10 and 11 work, or perhaps you have no use for this anymore.