chore: hardens docker image for production [#51]#63
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #51
Hardens the Docker image and the
e2e-dockerpipeline for production readiness and reliability.Changes
Docker hardening
python:3.13-slim@sha256:...) to prevent supply-chain driftappuserin theDockerfile.dockerignoreto exclude dev files from the imageDependency hygiene
requirements-dev.txt; production image only installsrequirements.txtnpmpackages to resolve 2 audit vulnerabilities (brace-expansionmoderate,flattedhigh)requirements-dev.txtfor the test jobDocker Compose & seeding reliability
mongodbservice (mongosh --eval "db.adminCommand('ping')") so dependent services wait for a ready database rather than a running containermongo-seedto usedepends_on: mongodb: condition: service_healthyinstead oflinkse2e-testsdependency onmongo-seed: condition: service_completed_successfullyso tests never run against an unseeded database--dropto bothmongoimportcalls to make seeding idempotentenrollmentcollection during seeding to prevent stale enrollment records from causing false duplicate-enrollment failures across test runsBash script quality
set -etomongo-setup.shso the script aborts on the first failure rather than silently continuingseed_collectionfunctionLinting
shellcheck-pypre-commit hook for bash script linting