Skip to content

fix(loop): pin transient driver units to the repo root via --working-directory #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robercano merged 1 commit into from
Jul 16, 2026
Merged

fix(loop): pin transient driver units to the repo root via --working-directory #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .claude/scripts/loop-daemon.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,8 +531,17 @@ run_driver() {
# running/lingering). Both failure modes otherwise look identical: some
# nonzero rc, no driver output, no other signal to tell them apart.
local start_marker; start_marker="$(mktemp -u "$state_dir/.driver-started.XXXXXX")"
# --working-directory is NOT optional: a transient --user unit defaults its
# WorkingDirectory to $HOME, and a driver started there never loads the
# repo's .claude/settings.local.json (bypassPermissions) — every gh call
# then dies on "requires approval" with no approver in headless mode, and
# the driver exits phantom. Burned 5 attempts on issue #97 (2026-07-16)
# before this line existed. The setsid fallback below doesn't need it: a
# plain child inherits the daemon's own cwd (the repo, per the service
# unit's WorkingDirectory).
systemd-run --user --wait --collect --quiet \
--unit="$unit" \
--working-directory="$root" \
-p "RuntimeMaxSec=$timeout_dur" \
--setenv="CLAUDE_CODE_PRINT_BG_WAIT_CEILING_MS=$CLAUDE_CODE_PRINT_BG_WAIT_CEILING_MS" \
--setenv="PATH=$PATH" \
Expand Down
2 changes: 2 additions & 0 deletions .claude/scripts/loop-daemon.test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,8 @@ check "scenario 11: RuntimeMaxSec threaded from LOOP_DRIVER_TIMEOUT=45m" bash -c
grep -qF -- "RuntimeMaxSec=45m" "$1"' _ "$dir11/systemd-run.args"
check "scenario 11: CLAUDE_CODE_PRINT_BG_WAIT_CEILING_MS passed via --setenv (issue #111 pt 4 preserved)" bash -c '
grep -qF -- "--setenv=CLAUDE_CODE_PRINT_BG_WAIT_CEILING_MS=0" "$1"' _ "$dir11/systemd-run.args"
check "scenario 11: --working-directory pins the transient unit to the repo root (not \$HOME)" bash -c '
grep -qF -- "--working-directory=$2" "$1"' _ "$dir11/systemd-run.args" "$dir11"
check "scenario 11: claude stub was invoked (under the transient unit)" [ -f "$dir11/claude.marker" ]
check "scenario 11: claude stub received the prompt text" bash -c 'grep -qF "issue #200" "$1"' _ "$dir11/claude.marker"
check "scenario 11: setsid (fallback path) was NOT invoked" [ ! -f "$dir11/setsid.marker" ]
Expand Down
Loading