fix: expose autocommit parameter on ODBCConnector - #78
Merged
Conversation
pyodbc defaults to autocommit=False, which makes it issue SQL_ATTR_AUTOCOMMIT = OFF during connect. Drivers for databases without transaction support reject that outright, so the connection fails before a connection object exists to mutate. Add an autocommit argument to ODBCConnector.__init__ that is passed through to pyodbc.connect(). Defaults to False to match pyodbc, so existing behavior is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ODBCConnectorcalledpyodbc.connect(conn_str)with noautocommitargument, so pyodbc used its default ofFalseand issuedSQL_ATTR_AUTOCOMMIT = OFFas part of connecting. Drivers for databases with no transaction support reject that, and the connection fails outright.Because the rejection happens during
pyodbc.connect(), there was no workaround — settingconnector.conn.autocommit = Trueafterward is too late, as the failing call has already happened.This adds an
autocommitargument toODBCConnector.__init__, passed straight through topyodbc.connect().Behavior
Defaults to
False, matching pyodbc's own default, so existing behavior is unchanged. The parameter is appended afterlogger, keeping positional calls compatible.Found while connecting to BigQuery over an ODBC DSN, where
autocommit=Trueis required.Tests
test_odbcconnector_init, which asserted on the exactconnectcall argsFalseTruepropagatespoetry run pytest --ignore=dev_env→ 192 passed.Release
Patch bump — run the Release workflow with
bump: patchafter merge.🤖 Generated with Claude Code