docs(display): trim the partial-flush comments by HaoboGu · Pull Request #1072 · rmk-rs/rmk

HaoboGu · 2026-08-19T14:26:06Z

Follow-up to #1070: shortens the comments added there (struct/with_staging docs and the gather rationale in flush), no code change.

github-actions · 2026-08-19T15:43:08Z

Size Report

Example	main	PR	Diff	.text
`use_config/nrf52832_ble`	398.4 KiB	398.4 KiB	+0.00% ⬇️	-4
`use_config/nrf52840_ble`	440.6 KiB	440.6 KiB	+0.00% ⬇️	-4
`use_config/nrf52840_ble_split (central)`	502.5 KiB	502.5 KiB	+0.00%	0
`use_config/nrf52840_ble_split (peripheral)`	317.5 KiB	317.5 KiB	+0.00%	0
`use_config/pi_pico_w_ble`	673.3 KiB	673.3 KiB	+0.00% ⬆️	+4
`use_config/rp2040`	146.1 KiB	146.1 KiB	+0.00% ⬇️	-4
`use_config/rp2040_split (central)`	159.8 KiB	159.8 KiB	+0.00%	0
`use_config/rp2040_split (peripheral)`	27.9 KiB	27.9 KiB	+0.00%	0
`use_config/stm32f1`	62.7 KiB	62.7 KiB	+0.00% ⬇️	-4
`use_config/stm32h7`	100.9 KiB	100.9 KiB	+0.00% ⬆️	+4
`use_rust/nrf52832_ble`	385.8 KiB	385.8 KiB	+0.00%	0
`use_rust/nrf52840_ble`	436.1 KiB	436.1 KiB	+0.00%	0
`use_rust/nrf52840_ble_split (central)`	505.8 KiB	505.8 KiB	+0.00% ⬇️	-4
`use_rust/nrf52840_ble_split (peripheral)`	315.3 KiB	315.3 KiB	+0.00%	0
`use_rust/pi_pico_w_ble`	672.6 KiB	672.6 KiB	+0.00%	0
`use_rust/rp2040`	145.6 KiB	145.6 KiB	+0.00%	0
`use_rust/rp2040_split (central)`	158.4 KiB	158.4 KiB	+0.00%	0
`use_rust/rp2040_split (peripheral)`	28.2 KiB	28.2 KiB	+0.00%	0
`use_rust/stm32f1`	61.9 KiB	61.9 KiB	+0.00% ⬇️	-4
`use_rust/stm32h7`	119.3 KiB	119.3 KiB	+0.00%	0

use_config/nrf52832_ble — 398.4 KiB → 398.4 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 365688	   8620	  33680	 407988	  639b4	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 365692	   8620	  33680	 407992	  639b8	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -4  -0.0%      -4    .text
 -36.8%     -28  [ = ]       0    [Unmapped]
  -0.0%     -32  -0.0%      -4    TOTAL

use_config/nrf52840_ble — 440.6 KiB → 440.6 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 398868	   8628	  43712	 451208	  6e288	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 398872	   8628	  43712	 451212	  6e28c	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +2.70Ki  [ = ]       0    .debug_str
  +0.1%    +372  [ = ]       0    .strtab
  +0.1%    +240  [ = ]       0    .debug_line
  +0.0%    +216  [ = ]       0    .debug_info
  +9.0%      +6  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.0%     -12  [ = ]       0    .debug_loc
  +0.0% +3.50Ki  -0.0%      -4    TOTAL

use_config/nrf52840_ble_split (central) — 502.5 KiB → 502.5 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 456856	   8684	  49056	 514596	  7da24	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 456856	   8684	  49056	 514596	  7da24	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

use_config/nrf52840_ble_split (peripheral) — 317.5 KiB → 317.5 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 291464	   8500	  25184	 325148	  4f61c	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 291464	   8500	  25184	 325148	  4f61c	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

use_config/pi_pico_w_ble — 673.3 KiB → 673.3 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 635748	      0	  53744	 689492	  a8554	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 635744	      0	  53744	 689488	  a8550	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +37  [ = ]       0    .debug_info
  +0.0%      +4  +0.0%      +4    .rodata
  -0.0%      -1  [ = ]       0    .debug_str
  -4.3%      -2  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_loc
  +0.0%     +28  +0.0%      +4    TOTAL

use_config/rp2040 — 146.1 KiB → 146.1 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 135704	      0	  13900	 149604	  24864	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 135708	      0	  13900	 149608	  24868	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +1.63Ki  [ = ]       0    .debug_str
  +0.2%    +238  [ = ]       0    .strtab
  +0.1%    +138  [ = ]       0    .debug_line
  +5.9%      +3  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.0%      -6  [ = ]       0    .debug_info
  +0.1% +1.99Ki  -0.0%      -4    TOTAL

use_config/rp2040_split (central) — 159.8 KiB → 159.8 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 148748	      0	  14844	 163592	  27f08	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 148748	      0	  14844	 163592	  27f08	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

use_config/rp2040_split (peripheral) — 27.9 KiB → 27.9 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  25696	     60	   2804	  28560	   6f90	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  25696	     60	   2804	  28560	   6f90	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +714  [ = ]       0    .debug_str
  +0.2%     +39  [ = ]       0    .strtab
  +6.2%      +3  [ = ]       0    [Unmapped]
  +0.1%    +756  [ = ]       0    TOTAL

use_config/stm32f1 — 62.7 KiB → 62.7 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  57784	     28	   6360	  64172	   faac	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  57788	     28	   6360	  64176	   fab0	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +63  [ = ]       0    .debug_str
  +0.0%     +52  [ = ]       0    .debug_info
  +0.0%      +9  [ = ]       0    .strtab
  -0.0%      -4  -0.0%      -4    .text
  +0.0%    +120  -0.0%      -4    TOTAL

use_config/stm32h7 — 100.9 KiB → 100.9 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  94928	    264	   8112	 103304	  19388	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  94924	    264	   8112	 103300	  19384	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  +0.0%      +4    .text
  -6.7%      -4  [ = ]       0    [Unmapped]
  -0.0%      -9  [ = ]       0    .strtab
  -0.0%     -52  [ = ]       0    .debug_info
  -0.0%     -63  [ = ]       0    .debug_str
  -0.0%    -124  +0.0%      +4    TOTAL

use_rust/nrf52832_ble — 385.8 KiB → 385.8 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 352768	   8620	  33624	 395012	  60704	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 352768	   8620	  33624	 395012	  60704	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +720  [ = ]       0    .debug_str
  +0.1%    +240  [ = ]       0    .debug_line
  +0.0%    +215  [ = ]       0    .debug_info
  +0.0%     +44  [ = ]       0    .strtab
  +0.0%     +42  [ = ]       0    .debug_loc
  +0.0%     +16  [ = ]       0    .debug_ranges
  -1.5%      -1  [ = ]       0    [Unmapped]
  +0.0% +1.25Ki  [ = ]       0    TOTAL

use_rust/nrf52840_ble — 436.1 KiB → 436.1 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 396964	   8628	  40944	 446536	  6d048	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 396964	   8628	  40944	 446536	  6d048	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1% +2.64Ki  [ = ]       0    .debug_str
  +0.1%    +376  [ = ]       0    .strtab
  +3.6%      +2  [ = ]       0    [Unmapped]
  -0.1%    -233  [ = ]       0    .debug_line
  +0.0% +2.79Ki  [ = ]       0    TOTAL

use_rust/nrf52840_ble_split (central) — 505.8 KiB → 505.8 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 458268	   8684	  51008	 517960	  7e748	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 458272	   8684	  51008	 517964	  7e74c	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +110  [ = ]       0    .debug_info
  +0.2%     +19  [ = ]       0    .debug_abbrev
  -0.0%      -4  -0.0%      -4    .text
  -0.0%     -27  [ = ]       0    .debug_line
 -42.3%     -30  [ = ]       0    [Unmapped]
  -0.0%     -35  [ = ]       0    .strtab
  -0.0%    -129  [ = ]       0    .debug_str
  -0.0%     -96  -0.0%      -4    TOTAL

use_rust/nrf52840_ble_split (peripheral) — 315.3 KiB → 315.3 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 289452	   8500	  24952	 322904	  4ed58	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 289452	   8500	  24952	 322904	  4ed58	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

use_rust/pi_pico_w_ble — 672.6 KiB → 672.6 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 635352	      0	  53424	 688776	  a8288	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 635352	      0	  53424	 688776	  a8288	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +5  [ = ]       0    .debug_info
  -0.0%      -2  [ = ]       0    .debug_loc
  -6.8%      -4  [ = ]       0    [Unmapped]
  -0.0%      -5  [ = ]       0    .debug_line
  -0.2%    -678  [ = ]       0    .strtab
  -0.1% -4.99Ki  [ = ]       0    .debug_str
  -0.1% -5.66Ki  [ = ]       0    TOTAL

use_rust/rp2040 — 145.6 KiB → 145.6 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 135332	      0	  13732	 149064	  24648	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 135332	      0	  13732	 149064	  24648	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +72  [ = ]       0    .debug_str
  +0.0%     +43  [ = ]       0    .debug_info
  +0.0%      +8  [ = ]       0    .strtab
  +2.2%      +1  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%     -58  [ = ]       0    .debug_line
  +0.0%     +56  [ = ]       0    TOTAL

use_rust/rp2040_split (central) — 158.4 KiB → 158.4 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 147656	      0	  14588	 162244	  279c4	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 147656	      0	  14588	 162244	  279c4	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +816  [ = ]       0    .debug_str
  +0.0%     +60  [ = ]       0    .strtab
  +0.0%     +10  [ = ]       0    .debug_loc
  -5.1%      -2  [ = ]       0    [Unmapped]
  +0.0%    +884  [ = ]       0    TOTAL

use_rust/rp2040_split (peripheral) — 28.2 KiB → 28.2 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  25796	     60	   3068	  28924	   70fc	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  25796	     60	   3068	  28924	   70fc	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +92  [ = ]       0    .debug_str
  +0.0%     +92  [ = ]       0    TOTAL

use_rust/stm32f1 — 61.9 KiB → 61.9 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  57120	     28	   6280	  63428	   f7c4	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  57124	     28	   6280	  63432	   f7c8	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +63  [ = ]       0    .debug_str
  +0.0%     +52  [ = ]       0    .debug_info
  +0.0%      +9  [ = ]       0    .strtab
  -0.0%      -4  -0.0%      -4    .text
  +0.0%    +120  -0.0%      -4    TOTAL

use_rust/stm32h7 — 119.3 KiB → 119.3 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 107836	    320	  14012	 122168	  1dd38	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 107836	    320	  14012	 122168	  1dd38	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +4.0%      +2  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%      -8  [ = ]       0    TOTAL

docs(display): trim the partial-flush comments

91cd97d

HaoboGu merged commit c82421d into main Aug 19, 2026
62 checks passed

Navigation Menu

Uh oh!

Uh oh!

docs(display): trim the partial-flush comments - #1072

docs(display): trim the partial-flush comments#1072
HaoboGu merged 1 commit into
mainfrom
docs/trim-lcd-flush-comments

HaoboGu commented Aug 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

HaoboGu commented Aug 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Size Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant