Skip to content

Fix slow multiprocessing#344

Open
riiswa wants to merge 8 commits into
rlberry-py:mainfrom
riiswa:fix/slow-multiprocessing
Open

Fix slow multiprocessing#344
riiswa wants to merge 8 commits into
rlberry-py:mainfrom
riiswa:fix/slow-multiprocessing

Conversation

@riiswa

@riiswa riiswa commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator

Description

This PR refer to #329

  • Add regression test
  • Add torch.multiprocessing
  • Add regression test Add joblib manager ?

@riiswa riiswa marked this pull request as draft July 24, 2023 08:48
@omardrwch

omardrwch commented Jul 24, 2023

Copy link
Copy Markdown
Member

Regarding "Replace multiprocessing by torch.multiprocessing", I wouldn't replace it, but add a "torch_multiprocessing" option (in AgentManager)

@riiswa

riiswa commented Jul 24, 2023

Copy link
Copy Markdown
Collaborator Author

@omardrwch okay I'll fix it

@riiswa riiswa marked this pull request as ready for review July 24, 2023 10:33
@riiswa riiswa force-pushed the fix/slow-multiprocessing branch from d24420c to 5c38cef Compare July 24, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants