feat: Core, Infrastructure, Model, Resources, ViewModels 폴더 정리 및 파일 이동#257
Merged
Conversation
rlarjsdn3
marked this pull request as ready for review
August 29, 2025 16:13
rlarjsdn3
requested review from
cestbonciel,
giseungNoh,
haejaejoon,
jseongee and
kwondohyun12
August 29, 2025 16:13
rlarjsdn3
force-pushed
the
move/core-viewmodel-folder
branch
from
August 29, 2025 16:18
2e51f5b to
f269b07
Compare
jseongee
reviewed
Aug 29, 2025
jseongee
left a comment
jseongee
left a comment
Collaborator
There was a problem hiding this comment.
Model 폴더도 복수형으로 짓는건 어때요? (Models)
Owner
Author
하는 김에 Infrastructures로도 하겠습니다~ |
rlarjsdn3
force-pushed
the
move/core-viewmodel-folder
branch
from
August 29, 2025 16:27
f269b07 to
143ca7e
Compare
jseongee
approved these changes
Aug 29, 2025
jseongee
left a comment
jseongee
left a comment
Collaborator
There was a problem hiding this comment.
Presentation도 Presentations로..?
Owner
Author
Okay |
rlarjsdn3
force-pushed
the
move/core-viewmodel-folder
branch
from
August 29, 2025 16:30
143ca7e to
fb5a635
Compare
Owner
Author
|
@cestbonciel @giseungNoh 확인해주신 후 병합하겠습니다~ |
cestbonciel
approved these changes
Aug 30, 2025
cestbonciel
left a comment
cestbonciel
left a comment
Collaborator
There was a problem hiding this comment.
구조 분리하신다고 고생하셨습니다~ 클린 아키텍처의 형태를 띄고 있네요 ㅎㅎ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 변경사항
@cestbonciel
@giseungNoh
BackgroundHeightUtils파일을 Personal 폴더로 옮겼습니다.@jseongee
🌈 이미지
정리 후 사진