dedupe shared helpers into internal/util#5
Merged
Conversation
authMethods dialed the SSH_AUTH_SOCK unix socket but never closed it, so a long-running session leaked one descriptor per Dial (plus one more per jump host). The agent is only consulted during authentication, which ssh.Dial / NewClientConn complete synchronously before Dial returns, so thread a cleanup func out through clientConfig and defer it once the handshake is done. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvNkzcutbfXNKAKCSy38H1
Every caller (connectCmd, listCmd) immediately re-sorts the result with ui.sortEntries by the user's chosen mode, so the dirs-first sort in List was never observed. Removing it also deletes the ASCII-only lessFold/toLower helpers, which disagreed with the Unicode-aware strings.ToLower used by the UI sort — a latent inconsistency that can no longer surface. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvNkzcutbfXNKAKCSy38H1
PathSize swallowed every walk error and unconditionally returned nil, so the error return advertised a failure mode that could not happen and forced a dead err check at the call site. Return just int64, matching its local-filesystem twin localPathSize. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvNkzcutbfXNKAKCSy38H1
This was referenced Jun 23, 2026
Two helpers were copy-pasted across packages; both now live in a single internal/util package: - A byte-count formatter existed as ui.humanSize (int64, "4.2M") and update.humanBytes (int, "4.2 MB"). Both are replaced by util.HumanBytes, giving one consistent style app-wide. The only visible change is the `rtr update` download message, now "4.2M" to match the listing style. - A "~" home-expansion helper existed three times: sshx.expandHome, transfer.expandHome, and ui.expandHomeUI. All three are replaced by util.ExpandHome, using the safe variant that returns the path unchanged when $HOME is unresolved. No behavior change beyond the update-message format. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LvNkzcutbfXNKAKCSy38H1
rjayasin
force-pushed
the
claude/shared-helpers
branch
from
June 23, 2026 04:16
6d101a3 to
f1308ec
Compare
rjayasin
changed the title
rjayasin
added a commit
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of 4 from the review stack. Base:
claude/sshx-fixes(PR #4) — the diff shown here is only this PR's changes; merge #4 first.Two helpers were copy-pasted across packages; both now live in a single
internal/utilpackage:ui.humanSize(int64, e.g.4.2M) andupdate.humanBytes(int, e.g.4.2 MB). Both are replaced byutil.HumanBytes, giving one consistent style app-wide. The only user-visible change is thertr updatedownload message, which now reads4.2Mto match the listing style.~home-expansion existed three times:sshx.expandHome,transfer.expandHome,ui.expandHomeUI. All three are replaced byutil.ExpandHome, using the safe variant that returns the path unchanged when$HOMEcan't be resolved.No behavior change beyond the update-message format.
go build,go vet,staticcheck -checks=all, andgo test -race ./...all pass.🤖 Generated with Claude Code