Allow to load ".set" files, which aggregate a set of coverage files - #8
Open
zxgio wants to merge 2 commits into
Open
Allow to load ".set" files, which aggregate a set of coverage files#8zxgio wants to merge 2 commits into
zxgio wants to merge 2 commits into
Conversation
Collaborator
|
can you please add a unit test for that ? |
Collaborator
|
ping @zxgio |
Author
|
Hi @oddcoder , sorry for the delay; in a couple of weeks, I'll try to refactor my code and add unit tests. Now I'm working overtime for a job-related deadline. |
Collaborator
|
ping @zxgio |
Author
|
I have refactored my code and added some tests. Locally it seems fine, I can't see what's wrong with the "Build phase" (I've never used Google Cloud Build) |
Collaborator
|
The google cloud thing is unrelated, I am in the middle of exams, will finish my exams and check, thanks in advance. |
Author
|
No problem, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows loading the result of the intersection/union/subtraction of a set of coverage files. A (text) ".set" file consists of a line with the desired operations and the list of coverage files to aggregate.