Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion rivetkit-typescript/packages/engine-runner/src/tunnel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -677,10 +677,35 @@ export class Tunnel {
const actor = await this.#runner.getAndWaitForActor(req.actorId);
if (!actor) {
this.log?.warn({
msg: "actor does not exist in handleRequestStart, request will leak",
msg: "ignoring request for unknown actor",
actorId: req.actorId,
requestId: requestIdStr,
});

const body = new TextEncoder().encode("Actor not found");

this.#runner.__sendToServer({
tag: "ToServerTunnelMessage",
val: {
messageId: {
gatewayId,
requestId,
messageIndex: 0,
},
messageKind: {
tag: "ToServerResponseStart",
val: {
status: 503,
headers: new Map([
["x-rivet-error", "runner.actor_not_found"],
["content-length", String(body.byteLength)],
]),
body: body.buffer,
stream: false,
},
},
},
});
return;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import { describe, expect, it, vi } from "vitest";
import { Tunnel } from "../src/tunnel";

describe("Tunnel missing actor request handling", () => {
it("returns a retryable 503 when a request arrives for an unloaded actor", async () => {
const sent: any[] = [];

const runner = {
log: undefined,
getAndWaitForActor: vi.fn().mockResolvedValue(undefined),
__sendToServer: vi.fn((message) => {
sent.push(message);
}),
} as any;

const tunnel = new Tunnel(runner);

const gatewayId = new Uint8Array(16).buffer;
const requestId = new Uint8Array(16).buffer;

await tunnel.handleTunnelMessage({
messageId: {
gatewayId,
requestId,
messageIndex: 0,
},
messageKind: {
tag: "ToClientRequestStart",
val: {
actorId: "missing-actor",
method: "GET",
path: "/",
headers: new Map(),
body: null,
stream: false,
},
},
} as any);

expect(sent).toHaveLength(1);
expect(sent[0].tag).toBe("ToServerTunnelMessage");
expect(sent[0].val.messageKind.tag).toBe("ToServerResponseStart");
expect(sent[0].val.messageKind.val.status).toBe(503);
expect(sent[0].val.messageKind.val.headers.get("x-rivet-error")).toBe(
"runner.actor_not_found",
);
expect(sent[0].val.messageKind.val.headers.get("content-length")).toBe(
"15",
);
expect(new TextDecoder().decode(sent[0].val.messageKind.val.body)).toBe(
"Actor not found",
);
expect(sent[0].val.messageKind.val.stream).toBe(false);
});
});