Add issue selector to pjm fix and MCP record_fix#2
Open
hanley-development wants to merge 9 commits into
Open
Conversation
Refactor issue handling in the run function to normalize issue IDs and check for existing issues. Preserve behavior for closing current issues while allowing targeted fixes.
Updated the fix command to accept an optional issue parameter to close a specific issue ID.
Updated function documentation and parameter names for clarity.
Clarify usage of record_fix function with issue_id
Adds import sys. Adds _console_safe(), _safe_echo(), and _rule(). Replaces Unicode separator rendering with encoding-safe rendering. Replaces the Unicode failed-attempt marker ✗ with ASCII x. Uses _safe_echo() for precheck output so hooks do not fail because the terminal cannot encode display characters.
fix: harden MCP git subprocess handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for closing a specific issue by ID when recording a confirmed fix.
Why
pjm attemptalready supports--issue, butpjm fixonly closes the active issue pointer. In real workflows, users may create issue#0002before finishing#0001. Without an issue selector, a verified fix for#0001can be recorded against the wrong active issue or leave#0001displayed as open.Changes
issueparameter toprojectmem.commands.fix.run.pjm fix --issue <id>.issue_idparameter to MCPrecord_fix.1,001, and0001all target0001.Example
pjm fix --issue 0001 "resolved MCP artifact leakage in skill/agent workflows"