sec-vuln: upgrade dependencies#9227
Merged
himadrisingh merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
Fixes * https://github.com/rilldata/rill/security/dependabot/459 * https://github.com/rilldata/rill/security/dependabot/460 * https://github.com/rilldata/rill/security/dependabot/457 * https://github.com/rilldata/rill/security/dependabot/458 * https://github.com/rilldata/rill/security/dependabot/461
Root cause: upgrading docker/compose/v5 to v5.1.2 pulled in gotest.tools/v3@v3.5.2 as a new transitive dependency. That library's init() registers flag.Bool("update", ...). Since dependency init() functions run before the importing package's
variable initializers, gotest.tools registers the flag first, and resolvers_test.go:58's var update = flag.Bool("update", ...) then panics with "flag redefined".
Fix (runtime/resolvers/resolvers_test.go):
- Replaced the package-level var update = flag.Bool(...) with an init() that only registers the flag if flag.Lookup("update") == nil (same pattern gotest.tools itself uses)
- Changed the usage in TestResolvers to look up the flag value via flag.Lookup("update") after flag.Parse() instead of dereferencing a package-level pointer
Contributor
Author
|
Root cause: upgrading docker/compose/v5 to v5.1.2 pulled in gotest.tools/v3@v3.5.2 as a new transitive dependency. That library's init() registers flag.Bool("update", ...). Since dependency init() functions run before the importing package's Fix (runtime/resolvers/resolvers_test.go):
|
begelundmuller
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Checklist: