Release - #730
Open
rhinestone-automations[bot] wants to merge 3 commits into
Open
Conversation
ci: streamline release verification
…10) (#729) `tokenRequests[].balance` ('spot' | 'perp') selects which HyperCore balance a delivery credits — the recipient's spot wallet or the default perp dex's margin account. The SDK never declared it and rebuilt token requests from named fields in two separate places, so the field was dropped before the network call and no consumer could deliver to spot even deliberately; every caller silently took the orchestrator's 'perp' default. Verified on dev 2026-08-05, where intents asking for spot completed, filled, and credited perp margin with nothing reporting it. Declared on both the EVM and non-EVM token-request arms and forwarded through `adaptTransaction` and `buildIntentRequest`. The non-EVM arm is the one that matters: `hyperCoreMainnet` is a `NonEvmChain`, because the SDK splits EVM from non-EVM by CAIP-2 namespace rather than by address shape — HyperCore addresses are EVM-shaped but `hypercore:` is not `eip155:`. `HyperCoreBalance` is exported from the package root, and a type-level assertion in `test/types` pins that a `targetChain: hyperCoreMainnet` request with a venue compiles, since the failure mode was a compile error no runtime test could catch. Pairs with rhinestonewtf/orchestrator#1825, which makes the venue required.
rhinestone-automations
Bot
added
the
ship
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes releasable changes from
maintoreleaseafter a successful@devpublish.