Skip to content

fix: surface unexpected Brevo API status codes (401/403/429/5xx)#6

Merged
eliot488995568 merged 3 commits into
masterfrom
fix/brevo-silent-failure-on-error-status
Jun 3, 2026
Merged

fix: surface unexpected Brevo API status codes (401/403/429/5xx)#6
eliot488995568 merged 3 commits into
masterfrom
fix/brevo-silent-failure-on-error-status

Conversation

@eliot488995568

@eliot488995568 eliot488995568 commented Jun 2, 2026

Copy link
Copy Markdown
Member

Closes #5
Throw ApiResponseException with the status code and response body instead of silently returning false, so callers can diagnose failures like a 401 caused by a non-whitelisted server IP.

Throw ApiResponseException with the status code and response body instead of silently returning false, so callers can diagnose failures like a 401 caused by a non-whitelisted server IP.
@eliot488995568 eliot488995568 self-assigned this Jun 2, 2026
@eliot488995568 eliot488995568 marked this pull request as draft June 2, 2026 07:49
@eliot488995568 eliot488995568 marked this pull request as ready for review June 2, 2026 09:19
Comment thread src/SubscribeMe/Exception/ApiResponseException.php Outdated
Comment thread src/SubscribeMe/Subscriber/ResponseValidationTrait.php Outdated
Comment thread src/SubscribeMe/Subscriber/BrevoSubscriber.php Outdated
Comment thread src/SubscribeMe/Subscriber/BrevoSubscriber.php Outdated
@eliot488995568 eliot488995568 merged commit d12a34e into master Jun 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BrevoSubscriber::subscribe() silently returns false on HTTP error responses (401/403/5xx) instead of throwing

2 participants