Isolate InvokerMemoryTest cases via @AfterEach cleanup#413
Merged
tillrohrmann merged 1 commit intoMay 4, 2026
Merged
Conversation
Tests in InvokerMemoryTest share a single deployment via the companion- scoped @RegisterExtension, and the extension only implements BeforeAllCallback. When a test failed or timed out, its in-flight invocations kept running on the cluster and held the global memory pool full, cascading into every subsequent test in the class. Add an @AfterEach that lists pending (status != 'completed') invocations, kills each, and waits for the invoker memory pool to drain to zero. The list+kill+assert step runs inside a single awaitility untilAsserted block, so transient admin-API failures (e.g. 503 during leadership changes, 404 from invocations that finished between query and kill) are absorbed by the existing ignoreExceptions() in utils.kt's untilAsserted wrapper. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
slinkydeveloper
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in InvokerMemoryTest share a single deployment via the companion- scoped @RegisterExtension, and the extension only implements BeforeAllCallback. When a test failed or timed out, its in-flight invocations kept running on the cluster and held the global memory pool full, cascading into every subsequent test in the class.
Add an @AfterEach that lists pending (status != 'completed') invocations, kills each, and waits for the invoker memory pool to drain to zero. The list+kill+assert step runs inside a single awaitility untilAsserted block, so transient admin-API failures (e.g. 503 during leadership changes, 404 from invocations that finished between query and kill) are absorbed by the existing ignoreExceptions() in utils.kt's untilAsserted wrapper.