Prepare workflow APIs for compose advisory integration#82
Merged
rockythorn merged 1 commit intoMay 29, 2026
Merged
Conversation
The status endpoint used asyncio.wait_for with a 1-second timeout to
guess whether a workflow was running or completed. This created
abandoned coroutines and couldn't distinguish failed/cancelled/timed-out
states — unreliable for the compose pipeline polling unattended for
hours.
Switch to Temporal's describe() API which returns a definitive status
enum (RUNNING, COMPLETED, FAILED, etc.) plus start/close times.
Also adds compose-pipeline support:
- Deterministic workflow IDs (rh-matcher-compose-v{major}) for
single-version triggers so Temporal deduplicates concurrent runs
- 409 Conflict response when a workflow is already running
- Admin UI status panel with live polling after triggering a workflow
rlhennig
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.wait_for(handle.result(), timeout=1.0)status heuristic with Temporal'sdescribe()API, which returns a definitive status enum (RUNNING,COMPLETED,FAILED, etc.) plus start/close timesrh-matcher-compose-v{major}) for single-version triggers so Temporal deduplicates concurrent runs viaid_reuse_policy=ALLOW_DUPLICATEThese changes prepare the Apollo server for compose pipeline integration, where
trigger-advisory-clone.sh(toolkit side) will call the trigger and status endpoints to ensure fresh advisory data beforeapollo_treegeneratesupdateinfo.xml.Test plan
rh-matcher-compose-v9for{"major_versions": [9]}runningwithstart_time,run_idviadescribe()API