Skip to content

Rewatch: use a single timestamp per compile pass #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhammerschmidt merged 3 commits into from
May 17, 2026
+9 −3
Merged

Rewatch: use a single timestamp per compile pass #8428

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31c3294
Rewatch: use a single timestamp per compile pass
cknitt May 17, 2026
5b31473
Rewatch: check cmi timestamp when detecting expired deps
cknitt May 17, 2026
76a695e
Rewatch: clarify compile timestamp generation
jfrolich May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions rewatch/src/build/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,12 @@ pub fn compile(
// though modules complete in arbitrary order.
results_buffer.sort_by(|a, b| a.module_name.cmp(&b.module_name));

// These timestamps are used as a compile-generation marker by
// mark_modules_with_expired_deps_dirty, not as precise wall-clock compile
// times. All modules successfully compiled in one pass are mutually
// up-to-date for that pass, so they must receive the same timestamp.
let compile_timestamp = SystemTime::now();

for msg in results_buffer {
let CompletionMsg {
module_name,
Expand Down Expand Up @@ -558,8 +564,8 @@ pub fn compile(

if result.is_ok() && interface_result.as_ref().is_none_or(|r| r.is_ok()) {
module.compile_dirty = false;
module.last_compiled_cmi = Some(SystemTime::now());
module.last_compiled_cmt = Some(SystemTime::now());
module.last_compiled_cmi = Some(compile_timestamp);
module.last_compiled_cmt = Some(compile_timestamp);
}

(compile_warning, compile_error, interface_warning, interface_error)
Expand Down Expand Up @@ -1208,7 +1214,7 @@ pub fn mark_modules_with_expired_deps_dirty(build_state: &mut BuildCommandState)
let dependent_module = build_state.modules.get(dependent).unwrap();
match dependent_module.source_type {
SourceType::SourceFile(_) => {
match (module.last_compiled_cmt, module.last_compiled_cmt) {
match (module.last_compiled_cmt, module.last_compiled_cmi) {
Copy link
Copy Markdown
Member Author

@cknitt cknitt May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated typo that Codex detected

(None, None) | (Some(_), None) | (None, Some(_)) => {
// println!(
// "🛑 {} is a dependent of {} but has no cmt/cmi",
Expand Down
Loading