Skip to content

Complete Agent Models workspace follow-ups#545

Open
crstdr wants to merge 1 commit into
repoprompt:mainfrom
crstdr:agent-models-issue-508-follow-ups
Open

Complete Agent Models workspace follow-ups#545
crstdr wants to merge 1 commit into
repoprompt:mainfrom
crstdr:agent-models-issue-508-follow-ups

Conversation

@crstdr

@crstdr crstdr commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make the Setup Wizard compute and apply Agent Models recommendations against the active global/workspace profile, reject stale targets, and label the affected scopes truthfully
  • expose and clear every stored role pin consistently, and validate synchronized Oracle/Compose profiles at the durable settings boundary
  • distinguish blocked future/incompatible settings schemas from corruption in telemetry handling, with focused regression coverage and persistence documentation
  • emit canonical notifications for every durable scope actually changed, including global MCP Presets combined with workspace Agent Models updates

Current-main integration

This follow-up is based directly on current main after #534. It preserves #534's AgentModelsOperationIdentity, stale-action revision guards, exact-scope mutation boundaries, and service-tier normalization.

Validation

  • Oracle final review: APPROVE
  • Fable 5 final review: APPROVE
  • RecommendationWizardScopedTargetTests: 5/5 passed
  • AutoRecommendationEngineScopedSettingsTests: 8/8 passed
  • MCPAgentRoleDefaultsServiceTests: 9/9 passed
  • SettingsJSONOnlyPersistenceTests: 75/75 passed
  • exact test ledger verification: 3,257 IDs
  • make dev-swift-build PRODUCT=RepoPrompt: passed
  • full make dev-test: one unrelated durable-artifact GC timing test failed; isolated suite rerun passed 9/9
  • targeted SwiftFormat/SwiftLint on touched files: passed
  • commit and push contribution preflights: passed
  • hosted GitHub CI: all required checks passed; shard 3 passed on rerun

Repo-wide lint remains blocked by existing SwiftFormat baseline findings in untouched files.

Closes #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent Models: complete workspace-scoped wizard and pin-state follow-ups after #275

1 participant