Extract process support into a focused SwiftPM module and test target#522
Open
morluto wants to merge 6 commits into
Open
Extract process support into a focused SwiftPM module and test target#522morluto wants to merge 6 commits into
morluto wants to merge 6 commits into
Conversation
…rt canary target This is the first canary step to separate subprocess-lifecycle and task-coordination substrate from the RepoPrompt app target. The move makes the dependency boundary explicit: RepoPromptProcessSupport depends only on RepoPromptShared, and RepoPromptApp depends on it. - Move Infrastructure/Process and Infrastructure/Concurrency into Sources/RepoPromptProcessSupport/ and update Package.swift target wiring. - Move CLIProcessRunnerLifecycleTests to Tests/RepoPromptProcessTests. - Update test-suite-contract-ledger and source-layout documentation. - Add RepoPromptProcessSupport to Sentry inAppInclude. - Remove unused Darwin import from CursorIntegrationConfiguration. - Add a narrow source-layout guardrail for RepoPromptProcessSupport. - Run SwiftFormat on affected files. macOS validation (build/test/run) is intentionally retained as a gap because this environment cannot run Swift builds requiring the Apple SDK.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
swift test --filternarrows execution, not target compilation. Small process-lifecycle tests still compile the broadRepoPromptAppand root test modules.This PR tests the architectural remedy on one bounded area. It extracts process execution and lifecycle support without attempting a repository-wide target rewrite.
Advances #416.
What changes
RepoPromptProcessSupportSwiftPM target.RepoPromptAppdepend on the lower-level module.RepoPromptProcessTestsand moves the lifecycle canary out of the root test target.packageaccess instead of widening the module to public API.Boundary
Existing features remain consumers. No compatibility wrapper or duplicate implementation is introduced.
Deliberate scope
This extracts one coherent canary only. It does not split every infrastructure area, redesign process APIs, or change conductor/cache behavior.
Review order
Package.swiftSources/RepoPromptProcessSupportTests/RepoPromptProcessTestsMost changed lines are file movement. Review the target graph and module boundary first.
Verification