VMIPushItem: Use converter for boot_mode - #671
Merged
Merged
Conversation
JAVGan
requested review from
chandwanitulsi,
rajulkumar and
rbikar
as code owners
August 26, 2025 15:15
Contributor
Author
JAVGan
force-pushed
the
bootmode_converter
branch
from
August 26, 2025 15:17
768d349 to
b52489a
Compare
This commit changes the `VMIPushItem` class to use a converter in the attribute `boot_mode` which is capable of properly converting it to the `BootMode` enum whenever possible. It fixes issues downstream where the information is given as a string instead of the Enum. Refers to SPSTRAT-600 Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
JAVGan
force-pushed
the
bootmode_converter
branch
from
August 26, 2025 15:55
b52489a to
bea4386
Compare
lslebodn
approved these changes
Aug 26, 2025
lslebodn
left a comment
lslebodn
left a comment
There was a problem hiding this comment.
Thank you very much for unit tests.
LGTM
rbikar
approved these changes
Aug 27, 2025
Contributor
Author
|
@rbikar feel free to merge it as I don't have permission to do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the
VMIPushItemclass to use a converter in the attributeboot_modewhich is capable of properly converting it to theBootModeenum whenever possible.It fixes issues downstream where the information is given as a string instead of the Enum.
Refers to SPSTRAT-600