Skip to content

Fix duplicate type property #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwalluck merged 1 commit into from
Aug 31, 2026
Merged

Fix duplicate type property #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/redhat/red/build/koji/model/json/BuildComponent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
*
* @author Honza Brázdil <jbrazdil@redhat.com>
*/
@JsonTypeInfo( use = Id.NAME, include = As.PROPERTY, property = TYPE )
@JsonTypeInfo( use = Id.NAME, include = As.EXISTING_PROPERTY, property = TYPE, visible = true )
@JsonSubTypes( {
@JsonSubTypes.Type( value = FileBuildComponent.class, name = "file" ),
@JsonSubTypes.Type( value = RPMBuildComponent.class, name = "rpm" )
Expand Down
13 changes: 9 additions & 4 deletions src/test/java/com/redhat/red/build/koji/model/json/BuildComponentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.redhat.red.build.koji.model.json;

import com.fasterxml.jackson.core.JsonParser;
import org.junit.Test;

import java.io.IOException;
Expand All @@ -32,16 +33,18 @@ public class BuildComponentTest
public void jsonRoundTripFile() throws VerificationException, IOException
{
FileBuildComponent src = new FileBuildComponent.Builder( "foo.txt" )
.withFileSize(42)
.withFileSize( 42 )
.withChecksum( "md5", "2a4b3cd54e6f" )
.build();

String json = mapper.writeValueAsString(src);
System.out.println(json);
String json = mapper.writeValueAsString( src );
System.out.println( json );

mapper.reader().with( JsonParser.Feature.STRICT_DUPLICATE_DETECTION ).readTree( json );

BuildComponent out = mapper.readValue( json, BuildComponent.class );

assertThat(out, equalTo(src));
assertThat( out, equalTo( src ) );
}

@Test
Expand All @@ -57,6 +60,8 @@ public void jsonRoundTripRPM() throws VerificationException, IOException
String json = mapper.writeValueAsString( src );
System.out.println( json );

mapper.reader().with( JsonParser.Feature.STRICT_DUPLICATE_DETECTION ).readTree( json );

BuildComponent out = mapper.readValue( json, BuildComponent.class );

assertThat( out, equalTo( src ) );
Expand Down
Loading