Skip to content

fix randomized X25519MLKEM768 key share consistency #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
T1nyBear wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

fix randomized X25519MLKEM768 key share consistency #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions u_parrots.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3339,7 +3339,8 @@ func generateRandomizedSpec(
points := SupportedPointsExtension{SupportedPoints: []byte{pointFormatUncompressed}}

curveIDs := []CurveID{}
if r.FlipWeightedCoin(id.Weights.CurveIDs_Append_X25519) && p.TLSVersMax == VersionTLS13 {
includeX25519MLKEM768 := r.FlipWeightedCoin(id.Weights.CurveIDs_Append_X25519) && p.TLSVersMax == VersionTLS13
if includeX25519MLKEM768 {
curveIDs = append(curveIDs, X25519MLKEM768)
}
if r.FlipWeightedCoin(id.Weights.CurveIDs_Append_X25519) || p.TLSVersMax == VersionTLS13 {
Expand Down Expand Up @@ -3399,9 +3400,11 @@ func generateRandomizedSpec(
if r.FlipWeightedCoin(id.Weights.KeyShare_Append_RandomGroups) {
ks.KeyShares = append(ks.KeyShares, KeyShare{Group: CurveP256})
}
if r.FlipWeightedCoin(id.Weights.KeyShare_Append_RandomGroups) {
ks.KeyShares = append([]KeyShare{{Group: X25519MLKEM768}}, ks.KeyShares...)
}
// Preserve PRNG progression for existing randomized seeds.
_ = r.FlipWeightedCoin(id.Weights.KeyShare_Append_RandomGroups)
}
if includeX25519MLKEM768 {
ks.KeyShares = append([]KeyShare{{Group: X25519MLKEM768}}, ks.KeyShares...)
}
pskExchangeModes := PSKKeyExchangeModesExtension{[]uint8{pskModeDHE}}
supportedVersionsExt := SupportedVersionsExtension{
Expand Down