getconf() bug fix + args for repo_prep script#204
Open
NaddiNadja wants to merge 3 commits into
Open
Conversation
Pull Request Test Coverage Report for Build 21136656586Details
💛 - Coveralls |
Collaborator
|
Did this block due to unrelated CI breakage? |
Contributor
Author
Collaborator
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
In the `getconf()` method, we allow users to overwrite configuration file values with local environment variables by replacing all dots in the key with underscores, as dots are not allowed in env var keys. The same goes for dashes however, so there was a bug where it was not possible to overwrite a key like `system-imaging.images.fedora-43-x86_64` because an env var key like "SYSTEM-IMAGING_IMAGES_FEDORA-43-x86_64" could not be defined. This commit changes the approach so that both dots and dashes should be replaced by underscores. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
In a previous commit, we added filtering for the test report, so that we can filter by e.g. passed or failed tests. However, when this is done, you cannot click the tests to see the testinfo or runlog. This commit fixes this by not adding `display:none` to items with the `.show` or `.collapse` classes. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will address this comment: #202 (comment)
And fix the first problem in #203