Skip to content

task: desugar-let-3variant#107

Merged
redpeacock78 merged 1 commit into
masterfrom
task/2026-07-02-desugar-let-3variant
Jul 2, 2026
Merged

task: desugar-let-3variant#107
redpeacock78 merged 1 commit into
masterfrom
task/2026-07-02-desugar-let-3variant

Conversation

@redpeacock78

Copy link
Copy Markdown
Owner

概要

_ds_result_ng_return?= unwrap失敗時分岐に、JSON型再設計(issue #44)で導入した3variantエラー型を追加する。

  • JsonParseError → 400
  • JsonTypeError → 422
  • JsonTooDeepError → 400

対象17 fixture + PR #106で追加されたJSON系fixture10件を再生成した(いずれも_ds_result_ng_return由来の3行追加のみ)。

テスト

  • bash tests/unit/dsl/run.sh → 183 passed, 0 failed
  • make test-unit → 572 passed, 0 failed, 0 skipped

Refs #44

_ds_result_ng_returnがJsonParseError/JsonTypeError/JsonTooDeepErrorを
未分類のまま500返却していた。core/json.awk・core/ctx.awkが返す
3variantエラー型に対応するステータス(400/422/400)を追加。

Refs #44
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@redpeacock78, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ecce2dbd-a713-49e6-9cf2-ff4adf59b4e0

📥 Commits

Reviewing files that changed from the base of the PR and between 0219275 and d9d3d70.

📒 Files selected for processing (28)
  • dsl/desugar_let.awk
  • tests/unit/dsl/cache_dispatch_question_eq/expected.awk
  • tests/unit/dsl/classify_validator_strips_untrusted/expected.awk
  • tests/unit/dsl/json_decode_t_nullable_unwrap/expected.awk
  • tests/unit/dsl/option_unwrap_error/expected.awk
  • tests/unit/dsl/option_unwrap_ok/expected.awk
  • tests/unit/dsl/qeq_auth_error/expected.awk
  • tests/unit/dsl/qeq_ctx_req_json_array_t/expected.awk
  • tests/unit/dsl/qeq_ctx_req_json_collision/expected.awk
  • tests/unit/dsl/qeq_ctx_req_json_map/expected.awk
  • tests/unit/dsl/qeq_ctx_req_json_nested_generic/expected.awk
  • tests/unit/dsl/qeq_ctx_req_json_object_map/expected.awk
  • tests/unit/dsl/qeq_ctx_req_json_record_t/expected.awk
  • tests/unit/dsl/qeq_json_decode_nested_generic/expected.awk
  • tests/unit/dsl/qeq_json_decode_t_list/expected.awk
  • tests/unit/dsl/qeq_json_scalar_decode_t/expected.awk
  • tests/unit/dsl/qeq_non_json_result_scalar/expected.awk
  • tests/unit/dsl/qeq_parse_error/expected.awk
  • tests/unit/dsl/safe_escape_html_ok/expected.awk
  • tests/unit/dsl/safe_fragment_interpolation_escape_ok/expected.awk
  • tests/unit/dsl/safe_namespace_escape_ok/expected.awk
  • tests/unit/dsl/safe_sink_ok/expected.awk
  • tests/unit/dsl/string_interpolation_untrusted_propagates/expected.awk
  • tests/unit/dsl/union_generic_top_level_split/expected.awk
  • tests/unit/dsl/untrusted_sig/expected.awk
  • tests/unit/dsl/untrusted_transform_ok/expected.awk
  • tests/unit/dsl/untrusted_trim_then_escape_html_ok/expected.awk
  • tests/unit/dsl/unwrap_union_option_result_ok/expected.awk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@redpeacock78 redpeacock78 merged commit 78dae77 into master Jul 2, 2026
5 checks passed
@redpeacock78 redpeacock78 deleted the task/2026-07-02-desugar-let-3variant branch July 2, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant