feat(helpers): add BUI-aware waits and shared catalog/notification helpers#122
Open
gashcrumb wants to merge 1 commit into
Open
feat(helpers): add BUI-aware waits and shared catalog/notification helpers#122gashcrumb wants to merge 1 commit into
gashcrumb wants to merge 1 commit into
Conversation
Member
Author
|
These changes were needed to update the tests in this PR, will remove those workspace-specific changes once this is available. |
…lpers - Extend WAIT_OBJECTS; add waitForAppReady() and fix openSidebar click - Add getSessionAuthToken, CatalogApiHelper, and RhdhNotificationsApi - Update NotificationPage with additive MUI + BUI selectors - Add unit tests and docs for all of the above - Bump version to 2.2.0 Assisted-By: Cursor Desktop rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
gashcrumb
force-pushed
the
add-bui-selectors
branch
from
2d1beca to
915e298
Compare
Member
Author
|
Thanks @subhashkhileri addressed those two comments, let me know if there's any other changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-By: Cursor Desktop
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED