Skip to content

chore: only sync release branches for lightspeed#464

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
Jdubrick:update-lightspeed-sync-action
Jul 7, 2026
Merged

chore: only sync release branches for lightspeed#464
openshift-merge-bot[bot] merged 1 commit into
redhat-developer:mainfrom
Jdubrick:update-lightspeed-sync-action

Conversation

@Jdubrick

@Jdubrick Jdubrick commented Jul 6, 2026

Copy link
Copy Markdown

Description of the change

Updates the sync scheduled job to only sync the release branches with changes. For 2.1.0 we will be making significant changes to the lightspeed configs and the resulting sync PRs will be confusing and breaking. We will manually keep them updated during the development process where necessary.

Which issue(s) does this PR fix or relate to

  • JIRA_issue_link

How to test changes / Special notes to the reviewer

Checklist

  • For each Chart updated, version bumped in the corresponding Chart.yaml according to Semantic Versioning.
  • For each Chart updated, variables are documented in the values.yaml and added to the corresponding README.md. The pre-commit utility can be used to generate the necessary content. Run pre-commit run --all-files to run the hooks and then push any resulting changes. The pre-commit Workflow will enforce this and warn you if needed.
  • JSON Schema template updated and re-generated the raw schema via the pre-commit hook.
  • Tests pass using the Chart Testing tool and the ct lint command.
  • If you updated the orchestrator-infra chart, make sure the versions of the Knative CRDs are aligned with the versions of the CRDs installed by the OpenShift Serverless operators declared in the values.yaml file. See Installing Knative Eventing and Knative Serving CRDs for more details.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick Jdubrick requested a review from a team as a code owner July 6, 2026 20:30
@Jdubrick

Jdubrick commented Jul 6, 2026

Copy link
Copy Markdown
Author

/cc @rm3l

@openshift-ci openshift-ci Bot requested a review from rm3l July 6, 2026 20:30
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Limit lightspeed sync workflow to release branches only

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Stop running the lightspeed config sync job against the main branch.
• Restrict scheduled sync PRs to the release branch matrix to avoid noisy/breaking updates.
Diagram

graph TD
  workflow[".github/workflows/sync-lightspeed-configs.yaml"] --> matrix{{"Release branches"}} --> sync_job(["Sync configs"]) --> pr["Sync PRs"]
  matrix --> repo[("Lightspeed repo")]

  subgraph Legend
    direction LR
    _file["Workflow file"] ~~~ _decision{{"Decision / matrix"}} ~~~ _job(["Job"]) ~~~ _db[("Repo")
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Match release branches via pattern (e.g., release-*)
  • ➕ Avoids updating the workflow when new release branches are created
  • ➕ Keeps intent (“only release branches”) explicit and scalable
  • ➖ GitHub Actions matrices don’t natively expand git refs; may require an extra discovery step/script
  • ➖ More moving parts than a static allowlist
2. Keep main in matrix but gate execution with conditional (if:)
  • ➕ Preserves ability to re-enable main quickly without editing the matrix
  • ➕ Can be toggled via repo/ORG variable
  • ➖ Still evaluates main in the matrix (can confuse readers and logs)
  • ➖ Higher risk of accidental re-enablement if the condition changes

Recommendation: The current explicit allowlist (removing main from the matrix) is the clearest and lowest-risk way to prevent confusing/breaking sync PRs during 2.1.0 work. If you expect frequent creation of new release branches, consider adding a lightweight branch-discovery step to generate the matrix dynamically.

Files changed (1) +0 / -1

Other (1) +0 / -1
sync-lightspeed-configs.yamlRemove main from lightspeed sync branch matrix +0/-1

Remove main from lightspeed sync branch matrix

• Updates the workflow matrix to stop syncing lightspeed configs against the main branch. The scheduled job will now run only for the configured release branch(es), reducing disruptive sync PRs during major config changes.

.github/workflows/sync-lightspeed-configs.yaml

@rhdh-qodo-merge

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@rhdh-qodo-merge rhdh-qodo-merge Bot added the enhancement New feature or request label Jul 6, 2026
@openshift-ci openshift-ci Bot added the lgtm label Jul 7, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 36591d0 into redhat-developer:main Jul 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants