feat(eks): enhancements and fixes for EKS#766
feat(eks): enhancements and fixes for EKS#766zdrapela wants to merge 4 commits intoredhat-developer:mainfrom
Conversation
1900154 to
1b896ed
Compare
|
@adrianriobo Hi, I tested this PR on creating an EKS cluster, but I haven't tested any other infra creation, which may be affected. |
281435c to
b3e1da7
Compare
|
hey nice contribution, yeah I think most of the changes should not affect other targets but I want to give a try, in any case can you clean a bit the commits? basically you can either group EKS improvements and Networking improvements? WDYT? |
f24206c to
dca05de
Compare
|
Sure, I split it 👍 |
|
@anjannath would you find time to review this one? |
Since MapPublicIp is set to true, nodes get public IPs directly and do not need a NAT gateway for outbound internet access.
…ging - Replace managed node group with self-managed ASG for spot price control - Add tekton task for EKS cluster management - Add resource tags to all EKS-specific AWS resources - Resolve EKS cluster creation failures - Fix EKS creation without AWS CLI - Extend EKS documentation
dca05de to
362c930
Compare
|
Thank you @anjannath, good points. I addressed your review comments. |
|
Hey we added a new release process for mapt offering now the binary too, I will wait for this PR to goes in and I release so if you have a moment and changes are good @anjannath LGTM and we can merge |
|
@zdrapela @adrianriobo seeing an error when trying to deploye |
|
@zdrapela how did you try it, either you set |
Summary
Self-managed node groups with spot support
spotPriceparameter to set maximum bid for spot instancesCluster reliability fixes
NodeConfig(required by AL2023 for proper pod networking withoutDescribeClusterAPI calls)WaitForCapacityTimeout,HealthCheckType, andHealthCheckGracePeriodto ASG so Pulumi waits for nodes to be InService before deploying addonsResolveConflictsOnCreateand extended timeouts to all EKS addonsNatGatewayModeNone) since EKS uses only public subnetsVPC endpoint extraction
EndpointsRequestmoduleServiceEndpointspattern from feat(aws): Optional service endpoints #754Other
Resolves #499