Skip to content

[CodeQuality] Skip abstract class on CompleteDynamicPropertiesRector #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jul 13, 2026
Merged

[CodeQuality] Skip abstract class on CompleteDynamicPropertiesRector #8182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...Quality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/skip_abstract_class.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Fixture;

abstract class SkipAbstractClass
{
public function set()
{
$this->value = 5;
}
}
5 changes: 5 additions & 0 deletions rules/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ private function shouldSkipClass(Class_ $class): bool
return true;
}

// abstract class property might be accessed from child class
if ($class->isAbstract()) {
return true;
}

$className = (string) $this->getName($class);
if (! $this->reflectionProvider->hasClass($className)) {
return true;
Expand Down
Loading