[Php82] Add ReadOnlyClassRector - #2296
Merged
Merged
Conversation
samsonasik
force-pushed
the
add-read-only-class-rector
branch
2 times, most recently
from
May 12, 2022 03:47
2c605d0 to
33c2f92
Compare
samsonasik
marked this pull request as draft
May 12, 2022 03:47
samsonasik
force-pushed
the
add-read-only-class-rector
branch
from
May 12, 2022 04:01
ede6efd to
7ce9170
Compare
samsonasik
commented
May 12, 2022
samsonasik
force-pushed
the
add-read-only-class-rector
branch
5 times, most recently
from
May 12, 2022 08:37
7ccc36a to
0dc8e9d
Compare
samsonasik
marked this pull request as ready for review
May 12, 2022 08:38
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
samsonasik
force-pushed
the
add-read-only-class-rector
branch
from
May 12, 2022 09:51
af7ad8c to
a9de1ae
Compare
Member
Author
|
rebased. |
Member
Author
|
I am merging it ;) |
Member
|
👍 |
| } | ||
| } | ||
|
|
||
| ?> |
Member
There was a problem hiding this comment.
There should be one more fixture with one readonly property and one normal one
Member
Author
There was a problem hiding this comment.
That willl be skipped, i will add more fixture
Comment on lines
+1
to
+8
| <?php | ||
|
|
||
| namespace Rector\Tests\Php82\Rector\Class_\ReadOnlyClassRector\Fixture; | ||
|
|
||
| final class SkipHasWritableProperty | ||
| { | ||
| private string $property; | ||
| } |
Member
There was a problem hiding this comment.
What about public readonly combination?
Member
Author
There was a problem hiding this comment.
That willl be skipped for writable+readonly, i will add more fixture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#7160