[CodeQuality] Move AssertClassToThisAssertRector hook from Class_ to ClassMethod#728
Merged
TomasVotruba merged 2 commits intoJul 14, 2026
Merged
Conversation
…ClassMethod The rule only ever rewrote Assert::assert*() calls inside class methods, so hooking on ClassMethod is more precise and avoids re-traversing the whole class. Static methods are now skipped with an early return instead of a DONT_TRAVERSE_CURRENT_AND_CHILDREN check inside the traversal callback; static closures and arrow functions are still skipped during traversal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule only ever rewrote
Assert::assert*()calls inside class methods, so hooking onClassMethodis more precise than hooking on the wholeClass_and re-traversing it.Behavior is unchanged:
final class SomeTest extends TestCase { public function testMe() { - Assert::assertSame(1, 1); + $this->assertSame(1, 1); } }Static methods are now skipped with an early return instead of a
DONT_TRAVERSE_CURRENT_AND_CHILDRENcheck inside the traversal callback:Static closures and arrow functions are still skipped during traversal.
The rule and its tests move from
Rector/Class_/toRector/ClassMethod/to match the hooked node type.