Skip to content

[CodeQuality] Use atLeast() instead of exactly() in DecorateWillReturnMapWithExpectsMockRector #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jul 13, 2026
Merged

[CodeQuality] Use atLeast() instead of exactly() in DecorateWillReturnMapWithExpectsMockRector #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lity/Rector/Expression/DecorateWillReturnMapWithExpectsMockRector/Fixture/fixture.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ final class SomeTest extends \PHPUnit\Framework\TestCase
public function test()
{
$someMock = $this->createMock(\stdClass::class);
$someMock->expects($this->exactly(2))->method('some')->willReturnMap([1, 2]);
$someMock->expects($this->atLeast(2))->method('some')->willReturnMap([1, 2]);
}
}

Expand Down
4 changes: 2 additions & 2 deletions rules/CodeQuality/Rector/Expression/DecorateWillReturnMapWithExpectsMockRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ protected function setUp(): void
{
$this->someMock = $this->createMock(SomeClass::class);

$this->someMock->expects($this->exactly(2))
$this->someMock->expects($this->atLeast(2))
->method("someMethod")
->willReturnMap([
["arg1", "arg2", "result1"],
Expand Down Expand Up @@ -166,7 +166,7 @@ private function refactorExpression(Expression $expression): bool
new Identifier('expects'),
[new Arg(new MethodCall(
new Variable('this'),
new Identifier('exactly'),
new Identifier('atLeast'),
[new Arg(new Int_($mapCount))]
))]
);
Expand Down
Loading