query: merge_outs no-op keeps outs Arc (Q-M3) - #263
Merged
Conversation
added 2 commits
August 25, 2026 20:03
Empty checked forced compose (covers_need([]) is true) so Occupied insert with new live and empty checked never widened, and an RCU retry of an already-covered empty-checked merge published a new Arc. already_covers is the one predicate for merge_outs and Occupied insert.
RCU retries cloned the incoming OutputRecords (script bytes) on every compose attempt. compose takes a slice; only the winning half copies new records. Closes algo-review Q-M3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge_outsno longer publishes a new pin-outs Arc on empty / already-coveredchecked+live(assemble stickyptr_eq). Occupied insert with emptycheckedstill widens whenlivehas new vouts. RCU compose borrowsliveinstead of cloning script bytes on every retry.Closes algo-review Q-M3.
Test plan
cargo test -p rbitcoin-query --lib batch_parents::