Skip to content

RT-18649: Remove certValidity #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbrag merged 2 commits into from
Jul 22, 2026
Merged

RT-18649: Remove certValidity #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb003ec
RT-18649: Remove certValidity
Jul 22, 2026
f5167d1
RT-18649: Fix test
Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Api/AcmeApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public function create(
?string $postalCode = null,
?string $city = null,
?bool $autoRenew = null,
?int $certValidity = null,
?Approver $approver = null,
bool $isQuote = false
): AcmeSubscriptionResponse | DomainQuote {
Expand All @@ -59,7 +58,6 @@ public function create(
'city' => $city,
'autoRenew' => $autoRenew,
'period' => $period,
'certValidity' => $certValidity,
'approver' => $approver?->toArray(),
], fn ($value) => ! is_null($value));

Expand Down
3 changes: 0 additions & 3 deletions src/Domain/AcmeSubscription.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ private function __construct(
public int $period,
public string $directoryUrl,
public bool $autoRenew,
public ?int $certValidity,
public ?DateTime $orgValidUntil,
public ?string $organizationId,
public string $status
Expand Down Expand Up @@ -56,7 +55,6 @@ public static function fromArray(array $json): AcmeSubscription
$json['period'],
$json['directoryUrl'],
$json['autoRenew'] ?? null,
$json['certValidity'] ?? null,
isset($json['orgValidUntil']) ? new DateTime($json['orgValidUntil']) : null,
$json['organizationId'] ?? null,
$json['status']
Expand All @@ -82,7 +80,6 @@ public function toArray(): array
'period' => $this->period,
'directoryUrl' => $this->directoryUrl,
'autoRenew' => $this->autoRenew,
'certValidity' => $this->certValidity,
'orgValidUntil' => $this->orgValidUntil?->format('Y-m-d\TH:i:s\Z'),
'organizationId' => $this->organizationId,
'status' => $this->status,
Expand Down
1 change: 0 additions & 1 deletion tests/Clients/Acme/AcmeApiCreateTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ static function () use ($response): Response {
'1234AB',
'City',
true,
199,
Approver::fromArray(
['firstName' => 'First Name',
'lastName' => 'Last Name',
Expand Down