[#1224] Redesign 19+ toggle as round circle icon next to logo#1225
Conversation
Replace the text pill toggle with a compact 20px round circle showing "19" — red fill + white text when active, muted gray when inactive. Adds aria-pressed for accessibility. Fixes #1224 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The visual styling of the toggle is moving in the right direction, but the layout still fails the main placement requirement. The button remains a separate flex child in a justify-between navbar, so it will be spaced away from the logo rather than immediately adjacent to the PlotLink text.
Findings
- [high] The 19 icon is not guaranteed to sit immediately to the right of the PlotLink logo text.
- File:
src/components/NavBar.tsx:69 - Suggestion: Group the logo link and the 19 button in a left-side flex wrapper, or otherwise make the button part of the logo cluster, so the layout is
[P logo] PlotLink [19 circle icon]on both desktop and mobile instead of a separately distributed navbar item.
- File:
Decision
Request changes because the PR does not satisfy the acceptance criterion requiring the icon to be positioned immediately right of the PlotLink logo text in the NavBar.
|
Reviewer 2 — APPROVE Clean, minimal diff (7 additions / 6 deletions). Matches the TopToon reference well:
No issues found. |
Wraps the logo link and 19+ toggle button in a single flex container so they always sit adjacent regardless of justify-between layout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Reviewer 2 — re-review APPROVE Fix looks correct: wrapping logo + 19+ button in a shared flex container ensures they stay adjacent under |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up fix groups the PlotLink logo and 19 icon in a shared flex container, so the icon now sits immediately next to the logo text as required. The round gray/off and red/on button styling, click handler, persisted preference path, and lack of duplicate toggle match the issue scope.
Findings
- None.
Decision
Approve. The previous placement blocker is resolved and the PR satisfies the acceptance criteria for issue #1224.
Summary
bg-red-600) with white text — matches TopToon referencebg-neutral-700) with subtle textaria-pressedattribute for accessibilityTest plan
?nsfw=1Fixes #1224
🤖 Generated with Claude Code