Skip to content

Move illustration checkbox next to Publish button#192

Merged
realproject7 merged 2 commits into
mainfrom
task/191-move-illustration-to-preview
May 14, 2026
Merged

Move illustration checkbox next to Publish button#192
realproject7 merged 2 commits into
mainfrom
task/191-move-illustration-to-preview

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Fixes #191

Summary

  • Moved the "Add illustrations in the plot" checkbox and upload area from the Edit tab to directly above the Publish to PlotLink button in the action bar
  • Users can now review content in Preview, add illustrations, and publish — all without switching tabs
  • Pre-publish validation and confirmation dialog unchanged

Test plan

  • Open a plot file (e.g. plot-01.md) — illustration checkbox visible above Publish button
  • Check the checkbox — upload area expands below it
  • Upload an image — markdown snippet appears with Copy button
  • Switch to Edit tab — no illustration checkbox there
  • Publish with illustrations — confirmation dialog still appears
  • Non-IPFS URL warnings still display correctly

🤖 Generated with Claude Code

The illustration upload UI now appears directly above the Publish button
in the action bar, so users can add illustrations without switching tabs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST CHANGES

Summary

The upload UI was moved near Publish, but it now lives in the shared action bar, which is rendered for both Preview and Edit. That does not satisfy the requirement that the illustration checkbox move to Preview and no longer show in Edit.

Findings

  • [medium] Illustration checkbox still appears while the Edit tab is active because the new block is inside the shared action bar rather than gated to the Preview tab.
    • File: app/web/components/PreviewPanel.tsx:707
    • Suggestion: Render the illustration checkbox/upload area only when activeTab === "preview" (or move it into Preview-only UI) so Edit has no illustration checkbox while Preview keeps it near Publish.

Decision

Requesting changes because one explicit acceptance criterion is not met. CI was still pending at review time.

Only render the illustration checkbox when activeTab === "preview"
so it does not appear while the Edit tab is active.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The requested fix is in place: the illustration checkbox/upload UI is now gated to activeTab === "preview", so it remains near Publish in Preview and no longer appears on Edit.

Findings

  • None.

Decision

Approving because the PR now satisfies issue #191 acceptance criteria and the changes remain minimal/focused. GitHub CI was still pending at review time.

@realproject7 realproject7 merged commit 836eb11 into main May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move illustration checkbox next to Publish button

2 participants