Move illustration checkbox next to Publish button#192
Conversation
The illustration upload UI now appears directly above the Publish button in the action bar, so users can add illustrations without switching tabs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The upload UI was moved near Publish, but it now lives in the shared action bar, which is rendered for both Preview and Edit. That does not satisfy the requirement that the illustration checkbox move to Preview and no longer show in Edit.
Findings
- [medium] Illustration checkbox still appears while the Edit tab is active because the new block is inside the shared action bar rather than gated to the Preview tab.
- File:
app/web/components/PreviewPanel.tsx:707 - Suggestion: Render the illustration checkbox/upload area only when
activeTab === "preview"(or move it into Preview-only UI) so Edit has no illustration checkbox while Preview keeps it near Publish.
- File:
Decision
Requesting changes because one explicit acceptance criterion is not met. CI was still pending at review time.
Only render the illustration checkbox when activeTab === "preview" so it does not appear while the Edit tab is active. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The requested fix is in place: the illustration checkbox/upload UI is now gated to activeTab === "preview", so it remains near Publish in Preview and no longer appears on Edit.
Findings
- None.
Decision
Approving because the PR now satisfies issue #191 acceptance criteria and the changes remain minimal/focused. GitHub CI was still pending at review time.
Fixes #191
Summary
Test plan
plot-01.md) — illustration checkbox visible above Publish button🤖 Generated with Claude Code