fix a regression introduced by fixYogaFlexBasisFitContentInMainAxis feature flag#1962
Closed
sammy-SC wants to merge 1 commit into
Closed
fix a regression introduced by fixYogaFlexBasisFitContentInMainAxis feature flag#1962sammy-SC wants to merge 1 commit into
sammy-SC wants to merge 1 commit into
Conversation
…eature flag Summary: X-link: facebook/react-native#56839 Limit the FixFlexBasisFitContent height optimization to non-measure container children inside scroll subtrees. This keeps Marketplace Home wrappers outside the ScrollView viewport-bounded while preserving the scroll remeasurement optimization. This regression was discovered during a recent QE where I tried to run enable this optimisation. Reviewed By: christophpurrer Differential Revision: D105167981
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105167981. |
|
This pull request has been merged in c64d060. |
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
May 19, 2026
…eature flag (#56839) Summary: X-link: react/yoga#1962 Pull Request resolved: #56839 changelog: [internal] Limit the FixFlexBasisFitContent height optimization to non-measure container children inside scroll subtrees. This keeps Marketplace Home wrappers outside the ScrollView viewport-bounded while preserving the scroll remeasurement optimization. This regression was discovered during a recent QE where I tried to run enable this optimisation. Reviewed By: christophpurrer Differential Revision: D105167981 fbshipit-source-id: bc988005507ebc1fc1688a8dc77c233e12ac2834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: react/react-native#56839
Limit the FixFlexBasisFitContent height optimization to non-measure container children inside scroll subtrees. This keeps Marketplace Home wrappers outside the ScrollView viewport-bounded while preserving the scroll remeasurement optimization.
This regression was discovered during a recent QE where I tried to run enable this optimisation.
Reviewed By: christophpurrer
Differential Revision: D105167981