Fix Kotlin property access syntax in Yoga Java test files#1959
Closed
CalixTang wants to merge 1 commit into
Closed
Fix Kotlin property access syntax in Yoga Java test files#1959CalixTang wants to merge 1 commit into
CalixTang wants to merge 1 commit into
Conversation
Summary: D104666348 migrated the Yoga Java test files to Kotlin but left Java-style getter/setter method calls (e.g. `node.setFlexDirection(...)`, `node.getLayoutWidth()`, `node.getData()`) which are invalid when calling Kotlin properties defined in `YogaNode.kt`. This diff converts all such calls to Kotlin property access syntax: - `node.setFlexDirection(x)` → `node.flexDirection = x` - `node.getLayoutWidth()` → `node.layoutWidth` - `node.isMeasureDefined()` → `node.isMeasureDefined` - `node.setData(x)` → `node.data = x` - And similar for all other properties Reviewed By: fkgozali, CalixTang Differential Revision: D105191609
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@CalixTang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105191609. |
|
This pull request has been merged in 5abc1c3. |
|
This pull request has been reverted by aa9c6fd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D104666348 migrated the Yoga Java test files to Kotlin but left Java-style getter/setter method calls (e.g.
node.setFlexDirection(...),node.getLayoutWidth(),node.getData()) which are invalid when calling Kotlin properties defined inYogaNode.kt.This diff converts all such calls to Kotlin property access syntax:
node.setFlexDirection(x)→node.flexDirection = xnode.getLayoutWidth()→node.layoutWidthnode.isMeasureDefined()→node.isMeasureDefinednode.setData(x)→node.data = xReviewed By: fkgozali, CalixTang
Differential Revision: D105191609