Set always_out_of_date on hermes-engine Replace Hermes phase#56912
Open
ramonclaudio wants to merge 1 commit into
Open
Set always_out_of_date on hermes-engine Replace Hermes phase#56912ramonclaudio wants to merge 1 commit into
ramonclaudio wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
The `[Hermes] Replace Hermes for the right configuration, if needed` script_phase has no declared outputs because it overwrites the prebuilt Hermes binary in place based on `$CONFIGURATION`. Xcode 14+ emits "will be run during every build because it does not specify any outputs" on every clean build of every project on the prebuilt-release tarball path. Set `script_phase[:always_out_of_date] = "1"` guarded by a `Pod::VERSION >= 1.13.0` check. Apple's documented opt-in for "yes, this phase intentionally runs every build." The phase still runs every build. The warning downgrades to a `note`. Matches the existing shape of the two sibling `Replace X for the right configuration` script_phases in the same package: - `React-Core-prebuilt.podspec` (react#52133) - `third-party-podspecs/ReactNativeDependencies.podspec` (react#49812) Same property previously accepted in react#48495 (`088fcb1e5d`) for `React-RCTFBReactNativeSpec.podspec` and the codegen podspecs (later consolidated in react#50317). `hermes-engine` is the last `Replace X` phase in the package without it.
ramonclaudio
force-pushed
the
fix/hermes-podspec-always-out-of-date
branch
from
6cf68e3 to
19af5c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
hermes-engine.podspec's[Hermes] Replace Hermes for the right configuration, if neededscript_phase is missing:always_out_of_date, so Xcode 14+ emits awill be run during every build because it does not specify any outputswarning on every clean iOS build of every project on the default prebuilt-release-tarball Hermes path. Set the flag using the samescript_phase = {...}+Pod::VERSION >= 1.13.0guard shape as the two siblingReplace X for the right configurationphases in this package (React-Core-prebuilt.podspecfrom #52133,ReactNativeDependencies.podspecfrom #49812). Same property previously accepted in #48495 forReact-RCTFBReactNativeSpec.podspec.hermes-engineis the lastReplace Xphase in the package without it.Changelog:
[IOS] [FIXED] - Set
always_out_of_dateon hermes-engine'sReplace Hermesscript phaseTest Plan:
pod install+xcodebuildon RN 0.85.3 against the default prebuilt Hermes path. The Hermes phase'swarning: ... will be run during every build because it does not specify any outputsdowngrades tonote: ... "Based on dependency analysis" is unchecked, matching the three sibling phases already fixed. GeneratedPods.xcodeproj/project.pbxprojcarriesalwaysOutOfDate = 1;on the phase. Script body unchanged, phase still runs every build, Hermes binary still replaced based on$CONFIGURATION.