docs: add Expo Snack demo embed#19
Merged
Merged
Conversation
Expose the public Snack alongside the example project in README and docs. Add the same Rspress Snack embed pattern used by the reference docs. Constraint: Do not change GitHub Actions setup in this follow-up Confidence: high Scope-risk: narrow Tested: CI=true pnpm docs:typecheck Tested: CI=true pnpm docs:build Tested: CI=true pnpm format:check targeted docs files Tested: git diff --check
Rspress dev should resolve React Refresh from pnpm's isolated graph. The hoisted linker made the refresh runtime get transformed by itself. The embedded Snack preview now opens on iOS for the docs demo. Constraint: pnpm hoisting changed the Rspress dev bundle runtime path Rejected: Disable HMR | masks the React Refresh resolution issue Confidence: high Scope-risk: moderate Tested: CI=true pnpm install --frozen-lockfile Tested: CI=true pnpm docs:typecheck Tested: CI=true pnpm docs:build Tested: git diff --check --cached Not-tested: Manual browser interaction with the embedded Snack
Record the README and docs quick start updates as a patch changeset. This keeps the package release notes aligned with the published docs and Snack demo. Constraint: README changes affect npm-facing package documentation Confidence: high Scope-risk: narrow Tested: git diff --check Not-tested: changeset version generation
🦋 Changeset detectedLatest commit: d848eb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying react-native-swipe-deck with
|
| Latest commit: |
d848eb3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49142e08.react-native-swipe-deck.pages.dev |
| Branch Preview URL: | https://docs-expo-snack-demo.react-native-swipe-deck.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a27b664fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Move Jest configuration out of package.json so the pnpm-specific transform allowlist is readable and keeps React Native test dependencies compiled. Constraint: pnpm stores dependencies under node_modules/.pnpm paths Rejected: Keep a long inline package.json regex | harder to review and maintain Confidence: high Scope-risk: narrow Tested: CI=true pnpm test Tested: CI=true pnpm format:check package.json jest.config.js Tested: CI=true pnpm typecheck Tested: CI=true pnpm build Tested: CI=true pnpm docs:build Tested: git diff --check
Rspress client navigation can remount the MDX page after Snack already loaded. The embed script scans only at load time, so each mount now recreates the current iframe. Constraint: Expo Snack embed script initializes by scanning DOM at load time Rejected: Re-run document-wide initialize | broader than needed and timing-sensitive Confidence: high Scope-risk: narrow Tested: CI=true pnpm docs:typecheck Tested: CI=true pnpm format:check targeted Snack files Tested: git diff --check targeted Snack files Tested: CI=true pnpm docs:build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the public Snack alongside the example project in README and docs.
Add the same Rspress Snack embed pattern used by the reference docs.