chore: keep root package publishable under pnpm#18
Merged
Conversation
Expo Snack made the packages/swipe-deck move look like the wrong abstraction. This keeps the published package at the repo root and moves tooling to pnpm. Constraint: Single npm package is published from the repository root Constraint: docs and example remain workspace projects Rejected: Keep packages/swipe-deck migration | no second publishable package exists Rejected: Leave Yarn hooks | local automation would diverge from CI and docs Confidence: high Scope-risk: moderate Directive: Keep nodeLinker hoisted unless React Native Metro resolution is revalidated Tested: CI=true pnpm install --no-frozen-lockfile Tested: CI=true pnpm install --frozen-lockfile Tested: CI=true pnpm format:check Tested: CI=true pnpm lint:ci Tested: CI=true pnpm typecheck Tested: CI=true pnpm build Tested: CI=true pnpm test --maxWorkers=2 --coverage Tested: CI=true pnpm docs:typecheck Tested: CI=true pnpm docs:build Tested: CI=true pnpm example:build Tested: CI=true pnpm changeset status Tested: CI=true pnpm pack --pack-destination /private/tmp/swipe-deck-root-pack-final Tested: git diff --check Not-tested: Expo Snack install after publishing the next npm version
The root package does not need to publish README-only assets. Jest also resolves React correctly with the existing worklets resolver. Constraint: pnpm uses a hoisted node_modules layout for React Native tooling Rejected: Keep assets in files | it only preserves a README image in the tarball Rejected: Keep moduleNameMapper | tests pass without the defensive mappings Confidence: high Scope-risk: narrow Tested: CI=true pnpm test --maxWorkers=2 --coverage Tested: CI=true pnpm format:check package.json Tested: CI=true pnpm pack --pack-destination /private/tmp/swipe-deck-no-assets Tested: git diff --check
🦋 Changeset detectedLatest commit: b035c6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expo Snack made the packages/swipe-deck move look like the wrong abstraction.
This keeps the published package at the repo root and moves tooling to pnpm.
Constraint: Single npm package is published from the repository root
Constraint: docs and example remain workspace projects