Skip to content

Add tag-triggered release workflow; loosen faraday dep; bump to 0.5.2 - #87

Open
msxavi wants to merge 1 commit into
developfrom
add-release-workflow
Open

Add tag-triggered release workflow; loosen faraday dep; bump to 0.5.2#87
msxavi wants to merge 1 commit into
developfrom
add-release-workflow

Conversation

@msxavi

@msxavi msxavi commented Aug 27, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds .github/workflows/release.yml, triggered by vX.Y.Z tag pushes, that publishes the gem to RubyGems.org (via OIDC trusted publishing) and to GitHub Packages (via the Actions GITHUB_TOKEN) — no long-lived credentials stored anywhere.
  • Refuses to publish unless the pushed tag's commit is reachable from develop.
  • Adds RELEASING.md documenting the release steps for the team and the one-time RubyGems.org Trusted Publisher setup required before the first run.
  • Loosens the faraday dependency from ~> 1.10 to >= 1.10 so consumers aren't held back from newer Faraday releases.
  • Bumps the gem version to 0.5.2 and updates CHANGELOG.md.

Mirrors the release workflow added in rdytech/happi#23, adapted for this gem.

Test plan

  • YAML validated locally (ruby -ryaml)
  • A superset gem owner configures the RubyGems.org Trusted Publisher for rdytech/superset-client / release.yml (see RELEASING.md)
  • Cut a real release following RELEASING.md and confirm the "Release" workflow run succeeds end-to-end
  • Confirm the version appears on rubygems.org and https://github.com/rdytech/superset-client/pkgs/rubygems/superset

🤖 Generated with Claude Code

Publishing now only happens through GitHub Actions, using RubyGems
OIDC trusted publishing and the Actions GITHUB_TOKEN, so no long-lived
credentials are stored. The workflow refuses to publish unless the
pushed tag's commit is reachable from develop. See RELEASING.md.

Also loosens the faraday dependency from ~> 1.10 to >= 1.10 so
consumers aren't held back from newer Faraday releases.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@msxavi
msxavi requested a review from jbat August 27, 2026 23:36
@msxavi

msxavi commented Aug 27, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@hanpeic hanpeic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread superset.gemspec
# >= 1.10 because the connections use Faraday's own `f.response :json`
# (Faraday::Response::Json), which only ships from 1.10.
spec.add_dependency "faraday", "~> 1.10"
spec.add_dependency "faraday", ">= 1.10"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants