RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per product in UI for residential gateway#119
Open
pavankumar464 wants to merge 11 commits into
Open
RDKB-64534 [OneStack][XB10] MTA Line details needs to be fixed as per product in UI for residential gateway#119pavankumar464 wants to merge 11 commits into
pavankumar464 wants to merge 11 commits into
Conversation
… product in UI for residential gateway
…r residential gateway
There was a problem hiding this comment.
Pull request overview
This PR updates the XB3 web UI templates to render MTA/voice line details based on the device-reported number of line entries, instead of being hard-coded for only 1–2 lines (targeting residential gateway product variants like XB10).
Changes:
- Generate the “Line Number” dropdown options dynamically in
voice_quality_metrics.jst. - Render CALLP/QoS per-line table rows dynamically in
qos.jst. - Render MTA Line Status per-line rows dynamically in
mta_Line_Status.jst.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
source/Styles/xb3/jst/voice_quality_metrics.jst |
Dynamically populates the line-number selector based on LineTableNumberOfEntries. |
source/Styles/xb3/jst/qos.jst |
Replaces hard-coded line 1/2 rows with a loop over all line entries. |
source/Styles/xb3/jst/mta_Line_Status.jst |
Replaces hard-coded line 1/2 status blocks with a loop over all line entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… product in UI for residential gateway
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
compares $_GET['line'] (string) against getStr("...LineTableNumberOfEntries")
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…s and numeric line validation Agent-Logs-Url: https://github.com/rdkcentral/webui/sessions/a1f497b4-bc28-469d-acde-49047bf774e4 Co-authored-by: pavankumar464 <57708013+pavankumar464@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d int validation Agent-Logs-Url: https://github.com/rdkcentral/webui/sessions/e3dfd3e0-6ed8-4baf-bbea-fda32f9bcbb3 Co-authored-by: pavankumar464 <57708013+pavankumar464@users.noreply.github.com>
Comment on lines
+144
to
+145
| $LineTableNumberOfEntries = getStr("Device.X_CISCO_COM_MTA.LineTableNumberOfEntries"); | ||
| for ($i = 1; $i <= $LineTableNumberOfEntries; $i++) { |
Comment on lines
+652
to
+659
| $("#mtalinediag1").text($.i18n("MTA Line 1 Diagnostics")); | ||
| $("#mtalinediag2").text($.i18n("MTA Line 2 Diagnostics")); | ||
| $("#mtalinediag3").text($.i18n("MTA Line 3 Diagnostics")); | ||
| $("#mtalinediag4").text($.i18n("MTA Line 4 Diagnostics")); | ||
| $("#mtalinediag5").text($.i18n("MTA Line 5 Diagnostics")); | ||
| $("#mtalinediag6").text($.i18n("MTA Line 6 Diagnostics")); | ||
| $("#mtalinediag7").text($.i18n("MTA Line 7 Diagnostics")); | ||
| $("#mtalinediag8").text($.i18n("MTA Line 8 Diagnostics")); |
Comment on lines
663
to
+670
| $("#mtalinstatmess2").text($.i18n("Line 1 Status:")); | ||
| $("#mtalinstatmess3").text($.i18n("Line 2 Status:")); | ||
| $("#mtalinstatmess4").text($.i18n("Line 3 Status:")); | ||
| $("#mtalinstatmess5").text($.i18n("Line 4 Status:")); | ||
| $("#mtalinstatmess6").text($.i18n("Line 5 Status:")); | ||
| $("#mtalinstatmess7").text($.i18n("Line 6 Status:")); | ||
| $("#mtalinstatmess8").text($.i18n("Line 7 Status:")); | ||
| $("#mtalinstatmess9").text($.i18n("Line 8 Status:")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.