RDKBNETWOR-80 : Transform to Nftables from Iptables#292
Open
vsai1990 wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
Reason for change: 1) Translate all the RDKB IPtables rules to nftables 2) write into /tmp/.nft and /tmp/.nft_v6 files and apply into netfilter 3) all the nftables rules are added under firewall_nft dir Test Procedure: RDKB Firewall functionality Risks: Medium
snayak002c
requested changes
May 11, 2026
Comment on lines
+7600
to
+7602
| if ( isNatReady ) | ||
| { | ||
| v_secure_system("iptables -t nat -%c prerouting_fromwan -p tcp -m tcp -d %s --dport %s -s %s -j DNAT --to-destination %s%s", | ||
| ciptableOprationCode,natip4, external_dest_port, external_ip, toip, port_modifier); | ||
| if (atoi(nft_enable) == 0) |
Contributor
There was a problem hiding this comment.
All changes must be guarded under a distro/CFLAG. The new changes should compile only when the distro is enabled, and there should be no impact when the distro is disabled.
| if (atoi(nft_enable) == 0) | ||
| { | ||
| v_secure_system("iptables -t nat -%c prerouting_fromlan -p udp -m udp -d %s --dport %s -s %s -j DNAT --to-destination %s%s", | ||
| ciptableOprationCode,lan_ipaddr, external_dest_port, external_ip, toip, port_modifier); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
Test Procedure: RDKB Firewall functionality
Risks: Medium