RDKEMW-17313 : Add /opt/logs copy for appgatewayversion.txt and appmanagersversion.txt#216
Open
kvfasil wants to merge 10 commits into
Open
RDKEMW-17313 : Add /opt/logs copy for appgatewayversion.txt and appmanagersversion.txt#216kvfasil wants to merge 10 commits into
kvfasil wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WPEFramework AppGateway and AppManager systemd unit files to capture version information into /opt/logs during service startup.
Changes:
- Added
ExecStartPretowpeframework-appgateway.serviceto append/etc/appgatewayversion.txtand/etc/appgatewaycpcversion.txtinto/opt/logs/version.txt. - Added
ExecStartPretowpeframework-appmanager.serviceto append/etc/appmanagersversion.txtinto/opt/logs/version.txtunder a conditional check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| systemd/system/wpeframework-appmanager.service | Adds a pre-start step intended to log AppManager version info to /opt/logs/version.txt. |
| systemd/system/wpeframework-appgateway.service | Adds pre-start steps to log AppGateway (and CPC) version info to /opt/logs/version.txt. |
added 4 commits
May 6, 2026 18:59
…onal execution check - Update ExecStartPre with simplified absolute path execution - Rename script to pop_appinfra_version.sh for clarity - Apply to both AppGateway and AppManager systemd services - Use '-' prefix to prevent service startup failure if script is missing
Comment on lines
+11
to
12
| ExecStartPre=-/usr/bin/pop_appinfra_version.sh | ||
| ExecStart=/usr/bin/PluginActivator org.rdk.AppGateway |
| @@ -8,4 +8,5 @@ ConditionPathExists=/opt/appgatewayenabled | |||
| [Service] | |||
| Type=oneshot | |||
| RemainAfterExit=yes | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.