Release/1.0.2#18
Closed
afranc083 wants to merge 14 commits into
Closed
Conversation
Tag 1.0.1
…eneric component Reason for change: 1. Clean up the code and resolve the build time warnings Test Procedure: Build & Playback Test verified Risks: None. Signed-off-by: antonyxavier_francis@comcast.com
…eneric component Reason for change: 1. Clean up the code and resolve the build time warnings Test Procedure: Build & Playback Test verified Risks: None. Signed-off-by: antonyxavier_francis@comcast.com
…om/rdkcentral/playready-rdk into feature/RDKMVE-2334-fix-build-warn
…om/rdkcentral/playready-rdk into feature/RDKMVE-2334-fix-build-warn
…om/rdkcentral/playready-rdk into feature/RDKMVE-2334-fix-build-warn
…om/rdkcentral/playready-rdk into feature/RDKMVE-2334-fix-build-warn
…om/rdkcentral/playready-rdk into feature/RDKMVE-2334-fix-build-warn
…om/rdkcentral/playready-rdk into feature/RDKMVE-2334-fix-build-warn
…om/rdkcentral/playready-rdk into feature/RDKMVE-2334-fix-build-warn
…warn RDKMVE-2334 : Fix Build Warnings in the playready-rdk and gst_svp_ext generic component
…ails with PlayReady Reason for change: updating ocdm playready Test Procedure: Build and verify. Signed-off-by: ligin_punoose@comcast.com
RDKMVE-2501: [Netflix] Netflix non-rialto binary protected playback fails with PlayReady
There was a problem hiding this comment.
Pull request overview
This PR prepares the 1.0.2 release by addressing build warnings and adjusting PlayReady session/SVP buffer handling, and updates the project changelog accordingly.
Changes:
- Remove unused variables and fix C++ declaration/typing issues to reduce build warnings.
- Initialize SVP secure memory region in the
MediaKeySessionconstructor variant implemented inMediaSessionExt.cpp. - Fix decryption buffer length handling in
MediaKeySession::Decrypt()and update key-status callback pointer casts.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
MediaSystem.cpp |
Removes unused variables to reduce compiler warnings. |
MediaSessionExt.cpp |
Adds SVP secure buffer initialization and adjusts key-status callback argument types. |
MediaSession.h |
Adjusts KeyId::getmBytes() mutability and fixes the Decrypt declaration. |
MediaSession.cpp |
Fixes decrypted-length handling in Decrypt() and updates key-status callback argument types. |
CHANGELOG.md |
Adds entries for the 1.0.2 release and date metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+77
to
+80
| if( 0 != svp_allocate_secure_buffers(m_pSVPContext, (void**)&m_stSecureBuffInfo, nullptr, nullptr, m_stSecureBuffInfo.SecureMemRegionSize)) | ||
| { | ||
| m_stSecureBuffInfo.SecureMemRegionSize = 0; | ||
| } |
| if ( keyId.getKeyIdOrder() == KeyId::KEYID_ORDER_GUID_LE ) | ||
| keyId.ToggleFormat(); | ||
| m_piCallback->OnKeyStatusUpdate("KeyUsable", keyId.getmBytes(), DRM_ID_SIZE); | ||
| m_piCallback->OnKeyStatusUpdate("KeyUsable", (const uint8_t *)keyId.getmBytes(), DRM_ID_SIZE); |
| void setKeyIdOrder(KeyIdOrder); | ||
| KeyIdOrder getKeyIdOrder(); | ||
| const DRM_BYTE* getmBytes(); | ||
| DRM_BYTE* getmBytes(); |
| for (DECRYPT_CONTEXT &p : m_DecryptContextVector) | ||
| { | ||
| m_piCallback->OnKeyStatusUpdate(MapDrToKeyMessage( dr ), p->keyId.getmBytes(), DRM_ID_SIZE); | ||
| m_piCallback->OnKeyStatusUpdate(MapDrToKeyMessage( dr ), (const uint8_t *)p->keyId.getmBytes(), DRM_ID_SIZE); |
| LoopEnd: | ||
| if ( m_piCallback ){ | ||
| m_piCallback->OnKeyStatusUpdate( MapDrToKeyMessage( dr ), keyId.getmBytes(), DRM_ID_SIZE); | ||
| m_piCallback->OnKeyStatusUpdate( MapDrToKeyMessage( dr ), (const uint8_t *)keyId.getmBytes(), DRM_ID_SIZE); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.