RDKEVL-6491: Phase1[RPI]: Vendor layer changes expected for westeros refactoring#361
Open
sajanasadhan99 wants to merge 1 commit into
Open
RDKEVL-6491: Phase1[RPI]: Vendor layer changes expected for westeros refactoring#361sajanasadhan99 wants to merge 1 commit into
sajanasadhan99 wants to merge 1 commit into
Conversation
…refactoring Reason for change: westeros refactoring where westeros is split into 5 different repositories Test Procedure: Build and verify Risks: Low Signed-off-by: Sajana Sadhan <sajana_sadhan@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this vendor layer to align with the Westeros refactoring (split into multiple repositories) by bumping Westeros versions, adjusting build-time paths, and updating package/dependency composition for RPi builds.
Changes:
- Bump the pinned Westeros version/SRCREV and add explicit version pinning for
essosrmgr. - Adjust
westeros-sinkbuild paths/symlinking logic to match the refactored source layout. - Remove the
westeros-soc-drmrecipe (and its patch) from this layer and addessosrmgrto the vendor package group.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| recipes-graphics/westeros/westeros-sink.bbappend | Updates autotools script path and adjusts symlinks/sed target location for the refactored layout. |
| recipes-graphics/westeros-soc/westeros-soc-drm.bb | Removes the DRM SoC recipe from this layer. |
| recipes-graphics/westeros-soc/files/set_and_get_resolution.patch | Removes a patch that was only used by the removed westeros-soc-drm recipe. |
| recipes-graphics/essosrmgr/essosrmgr.bbappend | Adds build flags and updates runtime dependency selection for upstream Wayland EGL vs. westeros-soc. |
| recipes-core/packagegroups/packagegroup-vendor-layer.bb | Adds essosrmgr to the rdkv-oss package list. |
| conf/include/vendor_pkg_versions.inc | Updates Westeros version pins and adds essosrmgr PV/PR/SRCREV pinning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
+29
| ln -sf ../westeros-sink.c ${AUTOTOOLS_SCRIPT_PATH} | ||
| ln -sf ../westeros-sink.h ${AUTOTOOLS_SCRIPT_PATH} |
| @@ -0,0 +1,4 @@ | |||
| CXXFLAGS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'use_westeros_essrmgr_uds', ' -DUSE_ESSRMGR_UDS_IMPL', '', d)}" | |||
| CXXFLAGS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'upstream_wayland_egl', ' -DUSE_ESS_BRCM_UPSTREAM_WAYLAND', '', d)}" | |||
| #RDEPENDS:${PN} += "${@bb.utils.contains('DISTRO_FEATURES','upstream_wayland_egl','','westeros-render-nexus',d)}" | |||
Comment on lines
150
to
151
| # Tip of westeros master as of Oct 01, 2025 | ||
| # Tag - Westeros-1.01.61 (revision - 9e675285a527115e65fcb0e7d2fc7a24a1e46e82) |
arun-madhavan-013
requested changes
May 13, 2026
| @@ -0,0 +1,4 @@ | |||
| CXXFLAGS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'use_westeros_essrmgr_uds', ' -DUSE_ESSRMGR_UDS_IMPL', '', d)}" | |||
| CXXFLAGS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'upstream_wayland_egl', ' -DUSE_ESS_BRCM_UPSTREAM_WAYLAND', '', d)}" | |||
Contributor
There was a problem hiding this comment.
I don't see these distro's enabled from any layer.
Could you please remove these if not required. Seems its a new file being added which does not alter anything at build time because those distro features are not enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: westeros refactoring where westeros is split into 5 different repositories
Test Procedure: Build and verify
Risks: Low