added debugs to check on stop input failure#260
Open
DakshayaniMV wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional logging around the HDMI-In “select port” RPC path to help diagnose failures when stopping/transitioning input.
Changes:
- Added server-side logs in
_dsHdmiInSelectPort()for profile branch selection and returned status. - Added client-side log of
rpcRetafterIARM_Bus_Call()fordsHdmiInSelectPort(). - Added wrapper-side logs in
HdmiInput::selectPort()to show ds error results and exception path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| rpc/srv/dsHdmiIn.c | Adds logging for TV vs non-TV profile selection and return path in the HDMI-In select-port RPC handler. |
| rpc/cli/dsHdmiIn.c | Adds a debug print of rpcRet for the HDMI-In select-port client RPC call. |
| ds/hdmiIn.cpp | Adds logging around dsHdmiInSelectPort() result and exception handling in the C++ wrapper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
855
to
+856
| param->result = dsHdmiInSelectPort(param->port,param->requestAudioMix, param->videoPlaneType,param->topMostPlane); | ||
| INT_ERROR("[%d][%s]: its TV Profile, dsHdmiInSelectPort param->result = %d \r\n", __LINE__, __FUNCTION__, param->result); |
Comment on lines
859
to
861
| { | ||
| INT_INFO("[%d][%s]: its Other Profile\r\n", __LINE__, __FUNCTION__); | ||
| INT_ERROR("[%d][%s]: its Other Profile, param result is ERR_General\r\n", __LINE__, __FUNCTION__); | ||
| param->result = dsERR_GENERAL; |
|
|
||
| IARM_BUS_Unlock(lock); | ||
|
|
||
| INT_ERROR("returning IARM_RESULT_SUCCESS in _dsHdmiInSelectPort"); |
| sizeof(param)); | ||
|
|
||
|
|
||
| printf("%s:%d - rpcRet=%d\n", __FUNCTION__, __LINE__, rpcRet); |
Comment on lines
250
to
+255
| dsError_t eError = dsHdmiInSelectPort ((dsHdmiInPort_t)Port, requestAudioMix ,(dsVideoPlaneType_t)videoPlaneType,topMost); | ||
|
|
||
| INT_ERROR("HdmiInput::selectPort : dsHdmiInSelectPort result eError = %d", eError); | ||
| // Throw an exception if there was an error | ||
| if (dsERR_NONE != eError) | ||
| { | ||
| INT_ERROR("HdmiInput::selectPort : Exception occurred eError = %d", eError); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.