Conversation
RDKEMW-17673 : Add info coverage gate to CI
RDKEMW-18340: Improve Minidump naming and crash-time fireboltState selection
* RDKEMW-19889: Kill orphaned grandchildren when main child exits * RDKEMW-19889: Kill orphaned grandchildren when main child exits
RDKEMW-19864: Update Dobby v3.20.0
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs main with develop, bringing in crash/minidump handling improvements, init-process cleanup behavior, and new GitHub Actions coverage-gating automation.
Changes:
- Minidump naming is now based on the crash-time file mtime and uses timestamped annotations to avoid recording post-crash state.
- Plugin annotations now track set-time and previous values to support “state at time of event” use-cases.
- Added CI workflow orchestration and a coverage comparison/baseline update mechanism.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| rdkPlugins/Minidump/source/Minidump.h | Updates minidump destination path helper signature to accept an fd. |
| rdkPlugins/Minidump/source/Minidump.cpp | Computes crash-time from fd mtime; selects correct firebolt state based on annotation timestamps; normalizes containerId for filenames. |
| pluginLauncher/lib/source/DobbyRdkPluginUtils.cpp | Adds annotation timestamps and preserves previous annotation values on overwrite/removal. |
| daemon/init/source/InitMain.cpp | Ensures orphaned descendants are SIGKILL’d when the main child exits/signals, preventing init wait() hangs. |
| .github/workflows/main-workflow.yml | Introduces a “main workflow” that runs L1 and performs informational coverage comparison + baseline update on develop pushes. |
| .github/workflows/L1-tests.yml | Converts L1 tests into a reusable workflow and renames artifacts to support downstream download. |
| .github/scripts/compare_coverage.py | Adds an lcov coverage parser/comparator and baseline JSON emitter (informational gate). |
| .github/scripts/compare_coverage_test.py | Adds unit + integration tests for the coverage comparison script. |
| CMakeLists.txt | Bumps project version to 3.20.0. |
| NOTICE | Adds 2026 RDK Management Apache 2.0 notice entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync main branch with develop
Type of Change
Requires Bitbake Recipe changes?
meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updatingSRC_REV)