fix: macOS compatibility - handle missing BlueZ import#87
Merged
Conversation
BlueZ is Linux-only. On macOS, importing BleakClientBlueZDBus raises ImportError. Wrap the import in a try/except and guard the isinstance check so the printer works on both Linux and macOS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Thanks @b1nmar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS,
BleakClientBlueZDBusfrombleak.backends.bluezdbus.clientis not available — BlueZ is Linux-only. This caused anImportErrorwhen running catprinter on macOS.Solution
BleakClientBlueZDBusimport in atry/except ImportErrorblock, setting it toNonewhen unavailable.isinstancecheck withBleakClientBlueZDBus and ...so the manual MTU negotiation only runs on Linux (where BlueZ is present).This makes the code fully compatible with both Linux and macOS with no behavior change on Linux.
Testing
Tested successfully on macOS with a GB01/GB02 cat printer.